fix: make args optional (#521)

summer-ji-eng · web-flow · commit ea3ae392fced · 2020-05-05T09:52:17.000-07:00
diff --git a/synthtool/gcp/common.py b/synthtool/gcp/common.py
@@ -94,7 +94,7 @@ def node_library(self, **kwargs) -> Path:
         kwargs["publish_token"] = node.get_publish_token(kwargs["metadata"]["name"])
 
         # generate root-level `src/index.ts` to export multiple versions and its default clients
-        if kwargs["versions"] and kwargs["default_version"]:
+        if "versions" in kwargs and "default_version" in kwargs:
             node.generate_index_ts(
                 versions=kwargs["versions"], default_version=kwargs["default_version"]
             )

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ def node_library(self, **kwargs) -> Path:`
`94`	`94`	`kwargs["publish_token"] = node.get_publish_token(kwargs["metadata"]["name"])`
`95`	`95`
`96`	`96`	# generate root-level `src/index.ts` to export multiple versions and its default clients
`97`		`- if kwargs["versions"] and kwargs["default_version"]:`
	`97`	`+ if "versions" in kwargs and "default_version" in kwargs:`
`98`	`98`	`node.generate_index_ts(`
`99`	`99`	`versions=kwargs["versions"], default_version=kwargs["default_version"]`
`100`	`100`	`)`