Skip to content

Commit 83552c4

Browse files
authored
feat: support Java 9+ compilation of generated libs (#889)
1 parent b711799 commit 83552c4

5 files changed

Lines changed: 25 additions & 0 deletions

File tree

rules_java_gapic/resources/gradle/client_grpc.gradle.tmpl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ dependencies {
1414
testImplementation 'io.grpc:grpc-stub:{{version.io_grpc}}'
1515
testImplementation 'io.grpc:grpc-netty-shaded:{{version.io_grpc}}'
1616
testImplementation '{{maven.junit_junit}}'
17+
18+
// TODO: remove when dropping Java 8 support.
19+
// https://github.com/googleapis/gapic-generator-java/issues/888
20+
implementation '{{maven.javax_annotation_javax_annotation_api}}'
21+
1722
{{extra_deps}}
1823
}
1924

rules_java_gapic/resources/gradle/client_grpcrest.gradle.tmpl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ dependencies {
1616
testImplementation 'io.grpc:grpc-stub:{{version.io_grpc}}'
1717
testImplementation 'io.grpc:grpc-netty-shaded:{{version.io_grpc}}'
1818
testImplementation '{{maven.junit_junit}}'
19+
20+
// TODO: remove when dropping Java 8 support.
21+
// https://github.com/googleapis/gapic-generator-java/issues/888
22+
implementation '{{maven.javax_annotation_javax_annotation_api}}'
23+
1924
{{extra_deps}}
2025
}
2126

rules_java_gapic/resources/gradle/client_rest.gradle.tmpl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ dependencies {
1111
implementation 'com.google.api:gax-httpjson:{{version.gax_httpjson}}'
1212
testImplementation 'com.google.api:gax-httpjson:{{version.gax_httpjson}}:testlib'
1313
testImplementation '{{maven.junit_junit}}'
14+
15+
// TODO: remove when dropping Java 8 support.
16+
// https://github.com/googleapis/gapic-generator-java/issues/888
17+
implementation '{{maven.javax_annotation_javax_annotation_api}}'
18+
1419
{{extra_deps}}
1520
}
1621

rules_java_gapic/resources/gradle/grpc.gradle.tmpl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ javadoc.options.encoding = 'UTF-8'
88
dependencies {
99
implementation 'io.grpc:grpc-stub:{{version.io_grpc}}'
1010
implementation 'io.grpc:grpc-protobuf:{{version.io_grpc}}'
11+
12+
// TODO: remove when dropping Java 8 support.
13+
// https://github.com/googleapis/gapic-generator-java/issues/888
14+
implementation '{{maven.javax_annotation_javax_annotation_api}}'
15+
1116
{{extra_deps}}
1217
}
1318

rules_java_gapic/resources/gradle/proto.gradle.tmpl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ dependencies {
1010
implementation '{{maven.com_google_guava_guava}}'
1111
implementation '{{maven.com_google_api_api_common}}'
1212
implementation '{{maven.com_google_api_grpc_proto_google_common_protos}}'
13+
14+
// TODO: remove when dropping Java 8 support.
15+
// https://github.com/googleapis/gapic-generator-java/issues/888
16+
implementation '{{maven.javax_annotation_javax_annotation_api}}'
17+
1318
{{extra_deps}}
1419
}
1520

0 commit comments

Comments
 (0)