[ggj][bazel] fix: add google/type:type_java_proto as default test dep (#571)

miraleung · web-flow · commit 3b7bb4042ee8 · 2020-11-25T17:22:33.000-08:00
* fix: handle empty method_signature in parsing protos

* fix: add google/type:type_java_proto as default test dep
diff --git a/rules_java_gapic/java_gapic.bzl b/rules_java_gapic/java_gapic.bzl
@@ -197,6 +197,7 @@ def java_gapic_library(
 
     # Test deps.
     actual_test_deps = test_deps + actual_deps + [
+        "@com_google_googleapis//google/type:type_java_proto",  # Commonly used.
         "@com_google_api_gax_java//gax-grpc:gax_grpc_testlib",
         "@com_google_api_gax_java//gax:gax_testlib",
         "@com_google_code_gson_gson//jar",
diff --git a/test/integration/BUILD.bazel b/test/integration/BUILD.bazel
@@ -55,7 +55,6 @@ java_gapic_library(
         "@com_google_googleapis//google/cloud/asset/v1:asset_java_proto",
         "@com_google_googleapis//google/iam/v1:iam_java_proto",
         "@com_google_googleapis//google/identity/accesscontextmanager/v1:accesscontextmanager_proto",
-        "@com_google_googleapis//google/type:type_java_proto",
     ],
 )
 
@@ -75,7 +74,6 @@ java_gapic_assembly_gradle_pkg(
         "@com_google_googleapis//google/cloud/asset/v1:asset_java_proto",
         "@com_google_googleapis//google/cloud/asset/v1:asset_proto",
         "@com_google_googleapis//google/cloud/orgpolicy/v1:orgpolicy_java_proto",
-        "@com_google_googleapis//google/identity/accesscontextmanager/type:type_java_proto",
         "@com_google_googleapis//google/identity/accesscontextmanager/v1:accesscontextmanager_java_proto",
     ],
 )

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,6 @@ java_gapic_library(`
`55`	`55`	`"@com_google_googleapis//google/cloud/asset/v1:asset_java_proto",`
`56`	`56`	`"@com_google_googleapis//google/iam/v1:iam_java_proto",`
`57`	`57`	`"@com_google_googleapis//google/identity/accesscontextmanager/v1:accesscontextmanager_proto",`
`58`		`- "@com_google_googleapis//google/type:type_java_proto",`
`59`	`58`	`],`
`60`	`59`	`)`
`61`	`60`
`@@ -75,7 +74,6 @@ java_gapic_assembly_gradle_pkg(`
`75`	`74`	`"@com_google_googleapis//google/cloud/asset/v1:asset_java_proto",`
`76`	`75`	`"@com_google_googleapis//google/cloud/asset/v1:asset_proto",`
`77`	`76`	`"@com_google_googleapis//google/cloud/orgpolicy/v1:orgpolicy_java_proto",`
`78`		`- "@com_google_googleapis//google/identity/accesscontextmanager/type:type_java_proto",`
`79`	`77`	`"@com_google_googleapis//google/identity/accesscontextmanager/v1:accesscontextmanager_java_proto",`
`80`	`78`	`],`
`81`	`79`	`)`