Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

samples: update library dep to 2.0.0#36

Merged
busunkim96 merged 1 commit into
masterfrom
busunkim96-patch-3
Jun 2, 2020
Merged

samples: update library dep to 2.0.0#36
busunkim96 merged 1 commit into
masterfrom
busunkim96-patch-3

Conversation

@busunkim96

@busunkim96 busunkim96 commented Jun 2, 2020

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2020
telpirion
telpirion approved these changes Jun 2, 2020
View reviewed changes

@telpirion telpirion left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Bu Sun!

@busunkim96 busunkim96 merged commit 6ce76b6 into master Jun 2, 2020
@busunkim96 busunkim96 deleted the busunkim96-patch-3 branch June 2, 2020 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sirtorry sirtorry Awaiting requested review from sirtorry

1 more reviewer

@telpirion telpirion telpirion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@telpirion telpirion

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@busunkim96 @telpirion @googlebot