fix: expose num_retries parameter for blob upload methods (#353)

HemangChothani · web-flow · commit fdabd6af74da · 2021-02-10T21:48:07.000Z
Fixes #352
diff --git a/google/cloud/storage/blob.py b/google/cloud/storage/blob.py
@@ -2367,6 +2367,7 @@ def upload_from_filename(
         self,
         filename,
         content_type=None,
+        num_retries=None,
         client=None,
         predefined_acl=None,
         if_generation_match=None,
@@ -2411,6 +2412,15 @@ def upload_from_filename(
             (Optional) The client to use.  If not passed, falls back to the
             ``client`` stored on the blob's bucket.
 
+        :type num_retries: int
+        :param num_retries:
+            Number of upload retries. By default, only uploads with
+            if_metageneration_match set will be retried, as uploads without the
+            argument are not guaranteed to be idempotent. Setting num_retries
+            will override this default behavior and guarantee retries even when
+            if_metageneration_match is not set.  (Deprecated: This argument
+            will be removed in a future release.)
+
         :type predefined_acl: str
         :param predefined_acl: (Optional) Predefined access control list
 
@@ -2465,6 +2475,7 @@ def upload_from_filename(
             self.upload_from_file(
                 file_obj,
                 content_type=content_type,
+                num_retries=num_retries,
                 client=client,
                 size=total_bytes,
                 predefined_acl=predefined_acl,
@@ -2480,6 +2491,7 @@ def upload_from_string(
         self,
         data,
         content_type="text/plain",
+        num_retries=None,
         client=None,
         predefined_acl=None,
         if_generation_match=None,
@@ -2515,6 +2527,15 @@ def upload_from_string(
             (Optional) Type of content being uploaded. Defaults to
             ``'text/plain'``.
 
+        :type num_retries: int
+        :param num_retries:
+            Number of upload retries. By default, only uploads with
+            if_metageneration_match set will be retried, as uploads without the
+            argument are not guaranteed to be idempotent. Setting num_retries
+            will override this default behavior and guarantee retries even when
+            if_metageneration_match is not set.  (Deprecated: This argument
+            will be removed in a future release.)
+
         :type client: :class:`~google.cloud.storage.client.Client`
         :param client:
             (Optional) The client to use.  If not passed, falls back to the
@@ -2573,6 +2594,7 @@ def upload_from_string(
             file_obj=string_buffer,
             size=len(data),
             content_type=content_type,
+            num_retries=num_retries,
             client=client,
             predefined_acl=predefined_acl,
             if_generation_match=if_generation_match,
