fix: remove trailing commas from error message constants (#505)

rjw57 · web-flow · commit d4a86ceb7a7c · 2021-07-15T16:22:12.000Z
The _DOWNLOAD_AS_STRING_DEPRECATED constant includes a dangling comma which makes it a tuple and not a string. This causes a TypeError as reported in #501. Fixes #501
diff --git a/google/cloud/storage/blob.py b/google/cloud/storage/blob.py
@@ -119,7 +119,7 @@
 _COMPOSE_IF_GENERATION_LIST_DEPRECATED = (
     "'if_generation_match: type list' is deprecated and supported for "
     "backwards-compatability reasons only.  Use 'if_source_generation_match' "
-    "instead' to match source objects' generations.",
+    "instead' to match source objects' generations."
 )
 _COMPOSE_IF_GENERATION_LIST_AND_IF_SOURCE_GENERATION_ERROR = (
     "Use 'if_generation_match' to match the generation of the destination "
@@ -130,14 +130,14 @@
     "'if_metageneration_match: type list' is deprecated and supported for "
     "backwards-compatability reasons only. Note that the metageneration to "
     "be matched is that of the destination blob. Please pass in a single "
-    "value (type long).",
+    "value (type long)."
 )
 _COMPOSE_IF_SOURCE_GENERATION_MISMATCH_ERROR = (
     "'if_source_generation_match' length must be the same as 'sources' length"
 )
 _DOWNLOAD_AS_STRING_DEPRECATED = (
     "Blob.download_as_string() is deprecated and will be removed in future. "
-    "Use Blob.download_as_bytes() instead.",
+    "Use Blob.download_as_bytes() instead."
 )
 
 

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@`
`119`	`119`	`_COMPOSE_IF_GENERATION_LIST_DEPRECATED = (`
`120`	`120`	`"'if_generation_match: type list' is deprecated and supported for "`
`121`	`121`	`"backwards-compatability reasons only. Use 'if_source_generation_match' "`
`122`		`- "instead' to match source objects' generations.",`
	`122`	`+ "instead' to match source objects' generations."`
`123`	`123`	`)`
`124`	`124`	`_COMPOSE_IF_GENERATION_LIST_AND_IF_SOURCE_GENERATION_ERROR = (`
`125`	`125`	`"Use 'if_generation_match' to match the generation of the destination "`
`@@ -130,14 +130,14 @@`
`130`	`130`	`"'if_metageneration_match: type list' is deprecated and supported for "`
`131`	`131`	`"backwards-compatability reasons only. Note that the metageneration to "`
`132`	`132`	`"be matched is that of the destination blob. Please pass in a single "`
`133`		`- "value (type long).",`
	`133`	`+ "value (type long)."`
`134`	`134`	`)`
`135`	`135`	`_COMPOSE_IF_SOURCE_GENERATION_MISMATCH_ERROR = (`
`136`	`136`	`"'if_source_generation_match' length must be the same as 'sources' length"`
`137`	`137`	`)`
`138`	`138`	`_DOWNLOAD_AS_STRING_DEPRECATED = (`
`139`	`139`	`"Blob.download_as_string() is deprecated and will be removed in future. "`
`140`		`- "Use Blob.download_as_bytes() instead.",`
	`140`	`+ "Use Blob.download_as_bytes() instead."`
`141`	`141`	`)`
`142`	`142`
`143`	`143`