From 447fc3c3b27ffd990892971d69b87535635be07b Mon Sep 17 00:00:00 2001 From: "gcf-owl-bot[bot]" <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Date: Fri, 21 Jul 2023 14:01:03 -0400 Subject: [PATCH 1/3] build(deps): [autoapprove] bump pygments from 2.13.0 to 2.15.0 (#979) Source-Link: https://github.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e Co-authored-by: Owl Bot Co-authored-by: Anthonios Partheniou --- .github/.OwlBot.lock.yaml | 4 ++-- .kokoro/requirements.txt | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml index ae4a522b9e..17c21d96d6 100644 --- a/.github/.OwlBot.lock.yaml +++ b/.github/.OwlBot.lock.yaml @@ -13,5 +13,5 @@ # limitations under the License. docker: image: gcr.io/cloud-devrel-public-resources/owlbot-python:latest - digest: sha256:39f0f3f2be02ef036e297e376fe3b6256775576da8a6ccb1d5eeb80f4c8bf8fb -# created: 2023-07-17T15:20:13.819193964Z + digest: sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e +# created: 2023-07-21T02:12:46.49799314Z diff --git a/.kokoro/requirements.txt b/.kokoro/requirements.txt index 67d70a1108..b563eb2844 100644 --- a/.kokoro/requirements.txt +++ b/.kokoro/requirements.txt @@ -396,9 +396,9 @@ pycparser==2.21 \ --hash=sha256:8ee45429555515e1f6b185e78100aea234072576aa43ab53aefcae078162fca9 \ --hash=sha256:e644fdec12f7872f86c58ff790da456218b10f863970249516d60a5eaca77206 # via cffi -pygments==2.13.0 \ - --hash=sha256:56a8508ae95f98e2b9bdf93a6be5ae3f7d8af858b43e02c5a2ff083726be40c1 \ - --hash=sha256:f643f331ab57ba3c9d89212ee4a2dabc6e94f117cf4eefde99a0574720d14c42 +pygments==2.15.0 \ + --hash=sha256:77a3299119af881904cd5ecd1ac6a66214b6e9bed1f2db16993b54adede64094 \ + --hash=sha256:f7e36cffc4c517fbc252861b9a6e4644ca0e5abadf9a113c72d1358ad09b9500 # via # readme-renderer # rich From 75e8a59ff5d7f15088b9c4ba5961345746e35bcc Mon Sep 17 00:00:00 2001 From: surbhigarg92 Date: Fri, 21 Jul 2023 19:28:42 +0000 Subject: [PATCH 2/3] feat: Set LAR as False (#980) * feat: Set LAR as False * Update google/cloud/spanner_dbapi/connection.py Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com> * Update google/cloud/spanner_v1/client.py Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com> --------- Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com> Co-authored-by: Anthonios Partheniou --- google/cloud/spanner_dbapi/connection.py | 13 +++++++------ google/cloud/spanner_v1/client.py | 9 +++++---- tests/unit/spanner_dbapi/test_connect.py | 4 ++-- tests/unit/test_client.py | 2 +- 4 files changed, 15 insertions(+), 13 deletions(-) diff --git a/google/cloud/spanner_dbapi/connection.py b/google/cloud/spanner_dbapi/connection.py index efbdc80f3f..6f5a9a4e0c 100644 --- a/google/cloud/spanner_dbapi/connection.py +++ b/google/cloud/spanner_dbapi/connection.py @@ -508,7 +508,7 @@ def connect( pool=None, user_agent=None, client=None, - route_to_leader_enabled=True, + route_to_leader_enabled=False, ): """Creates a connection to a Google Cloud Spanner database. @@ -547,9 +547,10 @@ def connect( :type route_to_leader_enabled: boolean :param route_to_leader_enabled: - (Optional) Default True. Set route_to_leader_enabled as False to - disable leader aware routing. Disabling leader aware routing would - route all requests in RW/PDML transactions to the closest region. + (Optional) Default False. Set route_to_leader_enabled as True to + enable leader aware routing. Enabling leader aware routing + would route all requests in RW/PDML transactions to the + leader region. :rtype: :class:`google.cloud.spanner_dbapi.connection.Connection` @@ -567,14 +568,14 @@ def connect( credentials, project=project, client_info=client_info, - route_to_leader_enabled=True, + route_to_leader_enabled=False, ) else: client = spanner.Client( project=project, credentials=credentials, client_info=client_info, - route_to_leader_enabled=True, + route_to_leader_enabled=False, ) else: if project is not None and client.project != project: diff --git a/google/cloud/spanner_v1/client.py b/google/cloud/spanner_v1/client.py index 70bb6310a1..955fd94820 100644 --- a/google/cloud/spanner_v1/client.py +++ b/google/cloud/spanner_v1/client.py @@ -116,9 +116,10 @@ class Client(ClientWithProject): :type route_to_leader_enabled: boolean :param route_to_leader_enabled: - (Optional) Default True. Set route_to_leader_enabled as False to - disable leader aware routing. Disabling leader aware routing would - route all requests in RW/PDML transactions to the closest region. + (Optional) Default False. Set route_to_leader_enabled as True to + enable leader aware routing. Enabling leader aware routing + would route all requests in RW/PDML transactions to the + leader region. :raises: :class:`ValueError ` if both ``read_only`` and ``admin`` are :data:`True` @@ -138,7 +139,7 @@ def __init__( client_info=_CLIENT_INFO, client_options=None, query_options=None, - route_to_leader_enabled=True, + route_to_leader_enabled=False, ): self._emulator_host = _get_spanner_emulator_host() diff --git a/tests/unit/spanner_dbapi/test_connect.py b/tests/unit/spanner_dbapi/test_connect.py index 86dde73159..a5b520bcbf 100644 --- a/tests/unit/spanner_dbapi/test_connect.py +++ b/tests/unit/spanner_dbapi/test_connect.py @@ -86,7 +86,7 @@ def test_w_explicit(self, mock_client): project=PROJECT, credentials=credentials, client_info=mock.ANY, - route_to_leader_enabled=True, + route_to_leader_enabled=False, ) client_info = mock_client.call_args_list[0][1]["client_info"] self.assertEqual(client_info.user_agent, USER_AGENT) @@ -120,7 +120,7 @@ def test_w_credential_file_path(self, mock_client): credentials_path, project=PROJECT, client_info=mock.ANY, - route_to_leader_enabled=True, + route_to_leader_enabled=False, ) client_info = factory.call_args_list[0][1]["client_info"] self.assertEqual(client_info.user_agent, USER_AGENT) diff --git a/tests/unit/test_client.py b/tests/unit/test_client.py index e67e928203..f8bcb709cb 100644 --- a/tests/unit/test_client.py +++ b/tests/unit/test_client.py @@ -59,7 +59,7 @@ def _constructor_test_helper( client_options=None, query_options=None, expected_query_options=None, - route_to_leader_enabled=True, + route_to_leader_enabled=None, ): import google.api_core.client_options from google.cloud.spanner_v1 import client as MUT From 35c7a36255b8e2d3174f7b09a5cbcd85f0f8ce20 Mon Sep 17 00:00:00 2001 From: "release-please[bot]" <55107282+release-please[bot]@users.noreply.github.com> Date: Sat, 22 Jul 2023 10:35:41 +0530 Subject: [PATCH 3/3] chore(main): release 3.38.0 (#981) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> --- .release-please-manifest.json | 2 +- CHANGELOG.md | 7 +++++++ google/cloud/spanner_admin_database_v1/gapic_version.py | 2 +- google/cloud/spanner_admin_instance_v1/gapic_version.py | 2 +- google/cloud/spanner_v1/gapic_version.py | 2 +- .../snippet_metadata_google.spanner.admin.database.v1.json | 2 +- .../snippet_metadata_google.spanner.admin.instance.v1.json | 2 +- .../snippet_metadata_google.spanner.v1.json | 2 +- 8 files changed, 14 insertions(+), 7 deletions(-) diff --git a/.release-please-manifest.json b/.release-please-manifest.json index 7af6d125c5..9f49ec500c 100644 --- a/.release-please-manifest.json +++ b/.release-please-manifest.json @@ -1,3 +1,3 @@ { - ".": "3.37.0" + ".": "3.38.0" } diff --git a/CHANGELOG.md b/CHANGELOG.md index 2f7fb71d64..f8f39f053a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,13 @@ [1]: https://pypi.org/project/google-cloud-spanner/#history +## [3.38.0](https://github.com/googleapis/python-spanner/compare/v3.37.0...v3.38.0) (2023-07-21) + + +### Features + +* Set LAR as False ([#980](https://github.com/googleapis/python-spanner/issues/980)) ([75e8a59](https://github.com/googleapis/python-spanner/commit/75e8a59ff5d7f15088b9c4ba5961345746e35bcc)) + ## [3.37.0](https://github.com/googleapis/python-spanner/compare/v3.36.0...v3.37.0) (2023-07-21) diff --git a/google/cloud/spanner_admin_database_v1/gapic_version.py b/google/cloud/spanner_admin_database_v1/gapic_version.py index fe7ae83874..e0c31c2ce4 100644 --- a/google/cloud/spanner_admin_database_v1/gapic_version.py +++ b/google/cloud/spanner_admin_database_v1/gapic_version.py @@ -13,4 +13,4 @@ # See the License for the specific language governing permissions and # limitations under the License. # -__version__ = "3.37.0" # {x-release-please-version} +__version__ = "3.38.0" # {x-release-please-version} diff --git a/google/cloud/spanner_admin_instance_v1/gapic_version.py b/google/cloud/spanner_admin_instance_v1/gapic_version.py index fe7ae83874..e0c31c2ce4 100644 --- a/google/cloud/spanner_admin_instance_v1/gapic_version.py +++ b/google/cloud/spanner_admin_instance_v1/gapic_version.py @@ -13,4 +13,4 @@ # See the License for the specific language governing permissions and # limitations under the License. # -__version__ = "3.37.0" # {x-release-please-version} +__version__ = "3.38.0" # {x-release-please-version} diff --git a/google/cloud/spanner_v1/gapic_version.py b/google/cloud/spanner_v1/gapic_version.py index fe7ae83874..e0c31c2ce4 100644 --- a/google/cloud/spanner_v1/gapic_version.py +++ b/google/cloud/spanner_v1/gapic_version.py @@ -13,4 +13,4 @@ # See the License for the specific language governing permissions and # limitations under the License. # -__version__ = "3.37.0" # {x-release-please-version} +__version__ = "3.38.0" # {x-release-please-version} diff --git a/samples/generated_samples/snippet_metadata_google.spanner.admin.database.v1.json b/samples/generated_samples/snippet_metadata_google.spanner.admin.database.v1.json index 9792a530b4..111a3cfca1 100644 --- a/samples/generated_samples/snippet_metadata_google.spanner.admin.database.v1.json +++ b/samples/generated_samples/snippet_metadata_google.spanner.admin.database.v1.json @@ -8,7 +8,7 @@ ], "language": "PYTHON", "name": "google-cloud-spanner-admin-database", - "version": "3.37.0" + "version": "3.38.0" }, "snippets": [ { diff --git a/samples/generated_samples/snippet_metadata_google.spanner.admin.instance.v1.json b/samples/generated_samples/snippet_metadata_google.spanner.admin.instance.v1.json index b310991955..6368c573e5 100644 --- a/samples/generated_samples/snippet_metadata_google.spanner.admin.instance.v1.json +++ b/samples/generated_samples/snippet_metadata_google.spanner.admin.instance.v1.json @@ -8,7 +8,7 @@ ], "language": "PYTHON", "name": "google-cloud-spanner-admin-instance", - "version": "3.37.0" + "version": "3.38.0" }, "snippets": [ { diff --git a/samples/generated_samples/snippet_metadata_google.spanner.v1.json b/samples/generated_samples/snippet_metadata_google.spanner.v1.json index b5ed408f98..c71c768c3d 100644 --- a/samples/generated_samples/snippet_metadata_google.spanner.v1.json +++ b/samples/generated_samples/snippet_metadata_google.spanner.v1.json @@ -8,7 +8,7 @@ ], "language": "PYTHON", "name": "google-cloud-spanner", - "version": "3.37.0" + "version": "3.38.0" }, "snippets": [ {