test: increase test coverage

larkee · larkee · commit e1a2ee47bfa4 · 2020-11-03T16:15:14.000+11:00
diff --git a/tests/unit/test__opentelemetry_tracing.py b/tests/unit/test__opentelemetry_tracing.py
@@ -121,9 +121,30 @@ def test_trace_grpc_error(self):
                 ) as span:
                     from google.api_core.exceptions import DataLoss
 
-                    raise _make_rpc_error(DataLoss)
+                    raise DataLoss("error")
 
             span_list = self.memory_exporter.get_finished_spans()
             self.assertEqual(len(span_list), 1)
             span = span_list[0]
             self.assertEqual(span.status.canonical_code, StatusCanonicalCode.DATA_LOSS)
+
+        def test_trace_codeless_error(self):
+            extra_attributes = {"db.instance": "database_name"}
+
+            expected_attributes = {
+                "db.type": "spanner",
+                "db.url": "spanner.googleapis.com:443",
+                "net.host.name": "spanner.googleapis.com:443",
+            }
+            expected_attributes.update(extra_attributes)
+
+            with self.assertRaises(GoogleAPICallError):
+                with _opentelemetry_tracing.trace_call(
+                        "CloudSpanner.Test", _make_session(), extra_attributes
+                ) as span:
+                    raise GoogleAPICallError("error")
+
+            span_list = self.memory_exporter.get_finished_spans()
+            self.assertEqual(len(span_list), 1)
+            span = span_list[0]
+            self.assertIsNone(span.status.canonical_code)
