From 00cbaf0a9504d3c39c87e1eb4831d0187a927743 Mon Sep 17 00:00:00 2001 From: Tianzi Cai Date: Tue, 22 Sep 2020 16:26:43 -0700 Subject: [PATCH 1/3] chore: remove unused region tags --- samples/snippets/quickstart/pub.py | 8 -------- samples/snippets/quickstart/sub.py | 8 -------- 2 files changed, 16 deletions(-) diff --git a/samples/snippets/quickstart/pub.py b/samples/snippets/quickstart/pub.py index 8585711f3..85402703f 100644 --- a/samples/snippets/quickstart/pub.py +++ b/samples/snippets/quickstart/pub.py @@ -14,16 +14,11 @@ # See the License for the specific language governing permissions and # limitations under the License. -# [START pubsub_quickstart_pub_all] import argparse import time -# [START pubsub_quickstart_pub_deps] from google.cloud import pubsub_v1 -# [END pubsub_quickstart_pub_deps] - - def get_callback(api_future, data, ref): """Wrap message data in the context of the callback function.""" @@ -48,10 +43,8 @@ def callback(api_future): def pub(project_id, topic_id): """Publishes a message to a Pub/Sub topic.""" - # [START pubsub_quickstart_pub_client] # Initialize a Publisher client. client = pubsub_v1.PublisherClient() - # [END pubsub_quickstart_pub_client] # Create a fully qualified identifier in the form of # `projects/{project_id}/topics/{topic_id}` topic_path = client.topic_path(project_id, topic_id) @@ -83,4 +76,3 @@ def pub(project_id, topic_id): args = parser.parse_args() pub(args.project_id, args.topic_id) -# [END pubsub_quickstart_pub_all] diff --git a/samples/snippets/quickstart/sub.py b/samples/snippets/quickstart/sub.py index efe008915..e7ed823f2 100644 --- a/samples/snippets/quickstart/sub.py +++ b/samples/snippets/quickstart/sub.py @@ -14,21 +14,14 @@ # See the License for the specific language governing permissions and # limitations under the License. -# [START pubsub_quickstart_sub_all] import argparse -# [START pubsub_quickstart_sub_deps] from google.cloud import pubsub_v1 -# [END pubsub_quickstart_sub_deps] - - def sub(project_id, subscription_id): """Receives messages from a Pub/Sub subscription.""" - # [START pubsub_quickstart_sub_client] # Initialize a Subscriber client subscriber_client = pubsub_v1.SubscriberClient() - # [END pubsub_quickstart_sub_client] # Create a fully qualified identifier in the form of # `projects/{project_id}/subscriptions/{subscription_id}` subscription_path = subscriber_client.subscription_path(project_id, subscription_id) @@ -66,4 +59,3 @@ def callback(message): args = parser.parse_args() sub(args.project_id, args.subscription_id) -# [END pubsub_quickstart_sub_all] From 2dc61413bcecb06f664aee7e78009af6683a036a Mon Sep 17 00:00:00 2001 From: Tianzi Cai Date: Tue, 22 Sep 2020 16:33:51 -0700 Subject: [PATCH 2/3] lint --- samples/snippets/quickstart/pub.py | 1 + samples/snippets/quickstart/sub.py | 1 + 2 files changed, 2 insertions(+) diff --git a/samples/snippets/quickstart/pub.py b/samples/snippets/quickstart/pub.py index 85402703f..404bcbb77 100644 --- a/samples/snippets/quickstart/pub.py +++ b/samples/snippets/quickstart/pub.py @@ -19,6 +19,7 @@ from google.cloud import pubsub_v1 + def get_callback(api_future, data, ref): """Wrap message data in the context of the callback function.""" diff --git a/samples/snippets/quickstart/sub.py b/samples/snippets/quickstart/sub.py index e7ed823f2..492d312f9 100644 --- a/samples/snippets/quickstart/sub.py +++ b/samples/snippets/quickstart/sub.py @@ -18,6 +18,7 @@ from google.cloud import pubsub_v1 + def sub(project_id, subscription_id): """Receives messages from a Pub/Sub subscription.""" # Initialize a Subscriber client From 1b093d950ac539e5d082e79e71ba24e71fc1f2d8 Mon Sep 17 00:00:00 2001 From: Tianzi Cai Date: Tue, 22 Sep 2020 17:16:36 -0700 Subject: [PATCH 3/3] update a region tag --- samples/snippets/publisher.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/snippets/publisher.py b/samples/snippets/publisher.py index d1b760280..78dff307d 100644 --- a/samples/snippets/publisher.py +++ b/samples/snippets/publisher.py @@ -134,7 +134,7 @@ def publish_messages_with_custom_attributes(project_id, topic_id): def publish_messages_with_error_handler(project_id, topic_id): - # [START pubsub_publish_messages_error_handler] + # [START pubsub_publish_with_error_handler] """Publishes multiple messages to a Pub/Sub topic with an error handler.""" import time @@ -173,7 +173,7 @@ def callback(f): time.sleep(5) print("Published message with error handler.") - # [END pubsub_publish_messages_error_handler] + # [END pubsub_publish_with_error_handler] def publish_messages_with_batch_settings(project_id, topic_id):