fix: Typecheck errors in samples/snippets/subscriber.py (#1186)

mukund-ananthu · gcf-owl-bot[bot] · parthea · web-flow · commit 3698450041cb · 2024-06-07T13:10:19.000-07:00
Co-authored-by: Owl Bot &lt;gcf-owl-bot[bot]@users.noreply.github.com&gt;
Co-authored-by: Anthonios Partheniou &lt;partheniou@google.com&gt;
diff --git a/samples/snippets/mypy.ini b/samples/snippets/mypy.ini
@@ -4,5 +4,9 @@ strict = True
 exclude = noxfile\.py
 warn_unused_configs = True
 
-[mypy-avro.*,backoff,flaky]
+; Ignore errors caused due to missing library stubs or py.typed marker
+; Refer https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-library-stubs-or-py-typed-marker
+; Errors ignored instead of adding stubs as a workaround, since this directory contains sample code
+; that does not affect the functionality of the client library.
+[mypy-avro.*,backoff,flaky,google.cloud.*]
 ignore_missing_imports = True
diff --git a/samples/snippets/subscriber.py b/samples/snippets/subscriber.py
@@ -528,8 +528,10 @@ def update_subscription_with_dead_letter_policy(
     )
 
     with subscriber:
-        subscription_after_update = subscriber.update_subscription(
-            request={"subscription": subscription, "update_mask": update_mask}
+        subscription_after_update: gapic_types.Subscription = (
+            subscriber.update_subscription(
+                request={"subscription": subscription, "update_mask": update_mask}
+            )
         )
 
     print(f"After the update: {subscription_after_update}.")
@@ -573,8 +575,10 @@ def remove_dead_letter_policy(
     )
 
     with subscriber:
-        subscription_after_update = subscriber.update_subscription(
-            request={"subscription": subscription, "update_mask": update_mask}
+        subscription_after_update: gapic_types.Subscription = (
+            subscriber.update_subscription(
+                request={"subscription": subscription, "update_mask": update_mask}
+            )
         )
 
     print(f"After removing the policy: {subscription_after_update}.")

Original file line number	Diff line number	Diff line change
`@@ -528,8 +528,10 @@ def update_subscription_with_dead_letter_policy(`
`528`	`528`	`)`
`529`	`529`
`530`	`530`	`with subscriber:`
`531`		`- subscription_after_update = subscriber.update_subscription(`
`532`		`- request={"subscription": subscription, "update_mask": update_mask}`
	`531`	`+ subscription_after_update: gapic_types.Subscription = (`
	`532`	`+ subscriber.update_subscription(`
	`533`	`+ request={"subscription": subscription, "update_mask": update_mask}`
	`534`	`+ )`
`533`	`535`	`)`
`534`	`536`
`535`	`537`	`print(f"After the update: {subscription_after_update}.")`
`@@ -573,8 +575,10 @@ def remove_dead_letter_policy(`
`573`	`575`	`)`
`574`	`576`
`575`	`577`	`with subscriber:`
`576`		`- subscription_after_update = subscriber.update_subscription(`
`577`		`- request={"subscription": subscription, "update_mask": update_mask}`
	`578`	`+ subscription_after_update: gapic_types.Subscription = (`
	`579`	`+ subscriber.update_subscription(`
	`580`	`+ request={"subscription": subscription, "update_mask": update_mask}`
	`581`	`+ )`
`578`	`582`	`)`
`579`	`583`
`580`	`584`	`print(f"After removing the policy: {subscription_after_update}.")`