Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.
This repository was archived by the owner on May 6, 2026. It is now read-only.

Remove Property._CREATION_COUNTER from ndb #22

Closed
Closed
Remove Property._CREATION_COUNTER from ndb#22
Assignees
chrisrossi
Labels
🚨This issue needs some love.triage meI really want to be triaged.
@dhermes

Description

@dhermes
dhermes
opened on Oct 26, 2018

Stepping into the original source, it's clear it was not used for anything:

$ cd datastore-ndb-python/
$ git grep -n '_creation_counter'
RELEASE_NOTES:112:- Issue 175: Add _creation_counter.
ndb/model.py:888:  __creation_counter_global = 0
ndb/model.py:942:    Property.__creation_counter_global += 1
ndb/model.py:943:    self._creation_counter = Property.__creation_counter_global
ndb/model_test.py:1230:    self.assertTrue(MyModel.foo._creation_counter <
ndb/model_test.py:1231:                    MyModel.bar._creation_counter <
ndb/model_test.py:1232:                    MyModel.baz._creation_counter)

It seems the stated goal in GoogleCloudPlatform/datastore-ndb-python#175 (when this was introduced) was never implemented.

@tseaver @chrisrossi WDYT?

@theacodes Do we have leeway to get rid of such a feature?

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.triage meI really want to be triaged.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions