Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

fix: mimic the pubsub test to clean up bigquery datasets - #639

Merged
leahecole merged 3 commits into
mainfrom
fix_635
Sep 30, 2022
Merged

fix: mimic the pubsub test to clean up bigquery datasets#639
leahecole merged 3 commits into
mainfrom
fix_635

Conversation

@leahecole

@leahecole leahecole commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

This should fix #635

@leahecole
leahecole requested a review from a team as a code owner September 30, 2022 14:44
@leahecole
leahecole requested review from a team and nicain September 30, 2022 14:44
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Sep 30, 2022
@product-auto-label product-auto-label Bot added the api: logging Issues related to the googleapis/python-logging API. label Sep 30, 2022
@leahecole leahecole changed the title mimic the pubsub test to clean up bigquery datasets fix: mimic the pubsub test to clean up bigquery datasets Sep 30, 2022
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@leahecole

leahecole commented Sep 30, 2022

Copy link
Copy Markdown
Contributor Author

Tests are failing on a quota error, I'll try to rerun

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@leahecole

leahecole commented Sep 30, 2022 •
edited by dandhlee
Loading

Copy link
Copy Markdown
Contributor Author

Looking at the project in question and am not seeing anything near the quota limit 🤔

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
dandhlee
dandhlee approved these changes Sep 30, 2022
View reviewed changes

@dandhlee dandhlee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit.

Comment thread samples/snippets/usage_guide.py
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 30, 2022
@leahecole
leahecole merged commit 44deb1b into main Sep 30, 2022
@leahecole
leahecole deleted the fix_635 branch September 30, 2022 18:45
@release-please release-please Bot mentioned this pull request Sep 30, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicain nicain Awaiting requested review from nicain nicain was automatically assigned from googleapis/python-samples-reviewers
2 more reviewers
@daniel-sanche daniel-sanche daniel-sanche approved these changes
@dandhlee dandhlee dandhlee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@daniel-sanche daniel-sanche

Labels

api: logging Issues related to the googleapis/python-logging API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Usage guide test leaving BQ leftovers

4 participants

@leahecole @daniel-sanche @dandhlee @yoshi-kokoro