fix(samples): Fix Typos in Batch process & get processor Samples

holtskinner · holtskinner · commit 8c204c523f18 · 2022-11-23T11:06:45.000-06:00
diff --git a/samples/snippets/batch_process_documents_processor_version_sample.py b/samples/snippets/batch_process_documents_processor_version_sample.py
@@ -66,7 +66,8 @@ def batch_process_documents_processor_version(
     #
 
     # Cloud Storage URI for the Output Directory
-    destination_uri = f"{gcs_output_bucket}/{gcs_output_uri_prefix}/"
+    # This must end with a trailing forward slash `/`
+    destination_uri = f"{gcs_output_bucket}/{gcs_output_uri_prefix}"
 
     gcs_output_config = documentai.DocumentOutputConfig.GcsOutputConfig(
         gcs_uri=destination_uri, field_mask=field_mask
diff --git a/samples/snippets/batch_process_documents_processor_version_sample_test.py b/samples/snippets/batch_process_documents_processor_version_sample_test.py
@@ -27,7 +27,7 @@
 processor_version_id = "pretrained-form-parser-v1.0-2020-09-23"
 gcs_input_uri = "gs://cloud-samples-data/documentai/invoice.pdf"
 input_mime_type = "application/pdf"
-gcs_output_uri_prefix = uuid4()
+gcs_output_uri_prefix = f"{uuid4()}/"
 field_mask = "text,pages.pageNumber"
 BUCKET_NAME = f"document-ai-python-{uuid4()}"
 
diff --git a/samples/snippets/batch_process_documents_sample.py b/samples/snippets/batch_process_documents_sample.py
@@ -64,7 +64,8 @@ def batch_process_documents(
     #
 
     # Cloud Storage URI for the Output Directory
-    destination_uri = f"{gcs_output_bucket}/{gcs_output_uri_prefix}/"
+    # This must end with a trailing forward slash `/`
+    destination_uri = f"{gcs_output_bucket}/{gcs_output_uri_prefix}"
 
     gcs_output_config = documentai.DocumentOutputConfig.GcsOutputConfig(
         gcs_uri=destination_uri, field_mask=field_mask
diff --git a/samples/snippets/batch_process_documents_sample_bad_input_test.py b/samples/snippets/batch_process_documents_sample_bad_input_test.py
@@ -25,7 +25,7 @@
 input_mime_type = "application/pdf"
 # following bucket contains .csv file which will cause the sample to fail.
 gcs_output_full_uri_with_wrong_type = "gs://documentai-beta-samples"
-gcs_output_uri_prefix = "test"
+gcs_output_uri_prefix = "test/"
 BUCKET_NAME = f"document-ai-python-{uuid4()}"
 
 
diff --git a/samples/snippets/batch_process_documents_sample_test.py b/samples/snippets/batch_process_documents_sample_test.py
@@ -26,7 +26,7 @@
 processor_id = "90484cfdedb024f6"
 gcs_input_uri = "gs://cloud-samples-data/documentai/invoice.pdf"
 input_mime_type = "application/pdf"
-gcs_output_uri_prefix = uuid4()
+gcs_output_uri_prefix = f"{uuid4()}/"
 field_mask = "text,pages.pageNumber"
 BUCKET_NAME = f"document-ai-python-{uuid4()}"
 
diff --git a/samples/snippets/get_processor_sample.py b/samples/snippets/get_processor_sample.py
@@ -31,7 +31,7 @@ def get_processor_sample(project_id: str, location: str, processor_id: str):
     client = documentai.DocumentProcessorServiceClient(client_options=opts)
 
     # The full resource name of the processor, e.g.:
-    # projects/project_id/locations/location/processor/processor_id
+    # projects/{project_id}/locations/{location}/processors/{processor_id}
     name = client.processor_path(project_id, location, processor_id)
 
     # Make GetProcessor request

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,8 @@ def batch_process_documents_processor_version(`
`66`	`66`	`#`
`67`	`67`
`68`	`68`	`# Cloud Storage URI for the Output Directory`
`69`		`- destination_uri = f"{gcs_output_bucket}/{gcs_output_uri_prefix}/"`
	`69`	+ # This must end with a trailing forward slash `/`
	`70`	`+ destination_uri = f"{gcs_output_bucket}/{gcs_output_uri_prefix}"`
`70`	`71`
`71`	`72`	`gcs_output_config = documentai.DocumentOutputConfig.GcsOutputConfig(`
`72`	`73`	`gcs_uri=destination_uri, field_mask=field_mask`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,8 @@ def batch_process_documents(`
`64`	`64`	`#`
`65`	`65`
`66`	`66`	`# Cloud Storage URI for the Output Directory`
`67`		`- destination_uri = f"{gcs_output_bucket}/{gcs_output_uri_prefix}/"`
	`67`	+ # This must end with a trailing forward slash `/`
	`68`	`+ destination_uri = f"{gcs_output_bucket}/{gcs_output_uri_prefix}"`
`68`	`69`
`69`	`70`	`gcs_output_config = documentai.DocumentOutputConfig.GcsOutputConfig(`
`70`	`71`	`gcs_uri=destination_uri, field_mask=field_mask`