Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

docs: add sample for writing data with Beam#80

Merged
tseaver merged 9 commits into
masterfrom
beam-sample
Aug 6, 2020
Merged

docs: add sample for writing data with Beam#80
tseaver merged 9 commits into
masterfrom
beam-sample

Conversation

@billyjacobson

@billyjacobson billyjacobson commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2020
@billyjacobson billyjacobson changed the title Writing data with Beam sample feat: Sample for writing data with Beam Jul 31, 2020
@busunkim96

busunkim96 commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

@billyjacobson Please use docs: . feat or fix will result in a bump in the library version. 😄

@billyjacobson billyjacobson changed the title feat: Sample for writing data with Beam docs: Sample for writing data with Beam Aug 3, 2020
@billyjacobson billyjacobson marked this pull request as ready for review August 3, 2020 18:44
@tseaver tseaver changed the title docs: Sample for writing data with Beam docs: add sample for writing data with Beam Aug 3, 2020
@billyjacobson billyjacobson added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@billyjacobson billyjacobson requested review from a team and busunkim96 August 3, 2020 20:53
busunkim96
busunkim96 reviewed Aug 4, 2020
View reviewed changes
Comment thread samples/beam/requirements.txt
Comment thread samples/beam/hello_world_write_test.py
Comment thread samples/beam/hello_world_write_test.py
@busunkim96 busunkim96 requested a review from a team August 4, 2020 06:35
@billyjacobson

billyjacobson commented Aug 4, 2020

Copy link
Copy Markdown
Contributor Author

@busunkim96 what is "docs-presubmit" It keeps failing for this PR, but I can't figure out what it is testing or how to fix it

@busunkim96

busunkim96 commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

@billyjacobson That job isn't set up yet on the GitHub side (it's OK to ignore it)

@billyjacobson billyjacobson added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 4, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 4, 2020
@tseaver

tseaver commented Aug 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

In order to avoid tripping over quota, I will tag this PR as automerge once PR #93 finishes its own auto-merge. Please don't hit the merge button until then. :(

@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Aug 5, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@gcf-merge-on-green

gcf-merge-on-green Bot commented Aug 6, 2020

Copy link
Copy Markdown

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green

gcf-merge-on-green Bot commented Aug 6, 2020

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 6, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@tseaver tseaver merged commit 6900290 into master Aug 6, 2020
@tseaver tseaver deleted the beam-sample branch August 6, 2020 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@billyjacobson @busunkim96 @tseaver @yoshi-kokoro @kolea2