fix: respect deadlines for column family operations (#687)

igorbernstein2 · web-flow · commit df2e64a79bbd · 2022-10-20T16:31:32.000-04:00
* feat: allow end users to override the deadline for manipulating column families

As a sideeffect this also fixes a bug where the default deadlines were not applied.

* limit scope of change to just use the default timeout

* lint
diff --git a/google/cloud/bigtable/column_family.py b/google/cloud/bigtable/column_family.py
@@ -20,6 +20,7 @@
 from google.cloud.bigtable_admin_v2.types import (
     bigtable_table_admin as table_admin_v2_pb2,
 )
+from google.api_core.gapic_v1.method import DEFAULT
 
 
 class GarbageCollectionRule(object):
@@ -275,7 +276,8 @@ def create(self):
         # data it contains are the GC rule and the column family ID already
         # stored on this instance.
         client.table_admin_client.modify_column_families(
-            request={"name": self._table.name, "modifications": [modification]}
+            request={"name": self._table.name, "modifications": [modification]},
+            timeout=DEFAULT,
         )
 
     def update(self):
@@ -302,7 +304,8 @@ def update(self):
         # data it contains are the GC rule and the column family ID already
         # stored on this instance.
         client.table_admin_client.modify_column_families(
-            request={"name": self._table.name, "modifications": [modification]}
+            request={"name": self._table.name, "modifications": [modification]},
+            timeout=DEFAULT,
         )
 
     def delete(self):
@@ -324,7 +327,8 @@ def delete(self):
         # data it contains are the GC rule and the column family ID already
         # stored on this instance.
         client.table_admin_client.modify_column_families(
-            request={"name": self._table.name, "modifications": [modification]}
+            request={"name": self._table.name, "modifications": [modification]},
+            timeout=DEFAULT,
         )
 
 
