removed unecessary pragma tags and reimplemented checking pandas minimum statement

kiraksi · kiraksi · commit 4cb86abff492 · 2023-11-20T14:41:25.000-08:00
diff --git a/tests/system/test_pandas.py b/tests/system/test_pandas.py
@@ -45,13 +45,11 @@
     "google.cloud.bigquery_storage", minversion="2.0.0"
 )
 
-if pandas is not None:  # pragma: NO COVER
+if pandas is not None:
     PANDAS_INSTALLED_VERSION = metadata.version("pandas")
-else:  # pragma: NO COVER
+else:
     PANDAS_INSTALLED_VERSION = "0.0.0"
 
-PANDAS_INT64_VERSION = "1.0.0"
-
 
 class MissingDataError(Exception):
     pass
@@ -315,7 +313,7 @@ def test_load_table_from_dataframe_w_automatic_schema(bigquery_client, dataset_i
 
 
 @pytest.mark.skipif(
-    PANDAS_INSTALLED_VERSION < PANDAS_INT64_VERSION,
+    PANDAS_INSTALLED_VERSION[0:2] in ["0."],
     reason="Only `pandas version >=1.0.0` is supported",
 )
 def test_load_table_from_dataframe_w_nullable_int64_datatype(
@@ -346,7 +344,7 @@ def test_load_table_from_dataframe_w_nullable_int64_datatype(
 
 
 @pytest.mark.skipif(
-    PANDAS_INSTALLED_VERSION < PANDAS_INT64_VERSION,
+    PANDAS_INSTALLED_VERSION[0:2] in ["0."],
     reason="Only `pandas version >=1.0.0` is supported",
 )
 def test_load_table_from_dataframe_w_nullable_int64_datatype_automatic_schema(
diff --git a/tests/unit/test__pandas_helpers.py b/tests/unit/test__pandas_helpers.py
@@ -63,9 +63,9 @@
 
 PANDAS_MINIUM_VERSION = "1.0.0"
 
-if pandas is not None:  # pragma: NO COVER
+if pandas is not None:
     PANDAS_INSTALLED_VERSION = metadata.version("pandas")
-else:  # pragma: NO COVER
+else:
     PANDAS_INSTALLED_VERSION = "0.0.0"
 
 
@@ -808,8 +808,8 @@ def test_list_columns_and_indexes_with_named_index_same_as_column_name(
 
 
 @pytest.mark.skipif(
-    pandas is None or PANDAS_INSTALLED_VERSION < PANDAS_MINIUM_VERSION,
-    reason="Requires `pandas version >= 1.0.0` which introduces pandas.NA",
+    PANDAS_INSTALLED_VERSION[0:2] in ["0."],
+    reason="Only `pandas version >=1.0.0` is supported",
 )
 def test_dataframe_to_json_generator(module_under_test):
     utcnow = datetime.datetime.utcnow()
diff --git a/tests/unit/test_client.py b/tests/unit/test_client.py
@@ -80,11 +80,9 @@
 from test_utils.imports import maybe_fail_import
 from tests.unit.helpers import make_connection
 
-PANDAS_MINIUM_VERSION = "1.0.0"
-
-if pandas is not None:  # pragma: NO COVER
+if pandas is not None:
     PANDAS_INSTALLED_VERSION = metadata.version("pandas")
-else:  # pragma: NO COVER
+else:
     PANDAS_INSTALLED_VERSION = "0.0.0"
 
 
@@ -8149,8 +8147,8 @@ def test_load_table_from_dataframe_unknown_table(self):
         )
 
     @unittest.skipIf(
-        pandas is None or PANDAS_INSTALLED_VERSION < PANDAS_MINIUM_VERSION,
-        "Only `pandas version >=1.0.0` supported",
+        PANDAS_INSTALLED_VERSION[0:2] in ["0."],
+        reason="Only `pandas version >=1.0.0` is supported",
     )
     @unittest.skipIf(pyarrow is None, "Requires `pyarrow`")
     def test_load_table_from_dataframe_w_nullable_int64_datatype(self):
@@ -8197,8 +8195,8 @@ def test_load_table_from_dataframe_w_nullable_int64_datatype(self):
         )
 
     @unittest.skipIf(
-        pandas is None or PANDAS_INSTALLED_VERSION < PANDAS_MINIUM_VERSION,
-        "Only `pandas version >=1.0.0` supported",
+        PANDAS_INSTALLED_VERSION[0:2] in ["0."],
+        reason="Only `pandas version >=1.0.0` is supported",
     )
     # @unittest.skipIf(pyarrow is None, "Requires `pyarrow`")
     def test_load_table_from_dataframe_w_nullable_int64_datatype_automatic_schema(self):
diff --git a/tests/unit/test_table.py b/tests/unit/test_table.py
@@ -74,9 +74,9 @@
 except (ImportError, AttributeError):  # pragma: NO COVER
     tqdm = None
 
-if pandas is not None:  # pragma: NO COVER
+if pandas is not None:
     PANDAS_INSTALLED_VERSION = metadata.version("pandas")
-else:  # pragma: NO COVER
+else:
     PANDAS_INSTALLED_VERSION = "0.0.0"
 
 
