Skip to content

fix: allow similarity search on table names with special characters#65

Merged
averikitsch merged 1 commit intomainfrom
jackwotherspoon-patch-1
Apr 15, 2024
Merged

fix: allow similarity search on table names with special characters#65
averikitsch merged 1 commit intomainfrom
jackwotherspoon-patch-1

Conversation

@jackwotherspoon
Copy link
Copy Markdown
Contributor

@jackwotherspoon jackwotherspoon commented Apr 15, 2024

Table name should use backticks around it to avoid breakage by special characters (such as -)

Will add a test for this to be properly tested

@jackwotherspoon jackwotherspoon self-assigned this Apr 15, 2024
@jackwotherspoon jackwotherspoon requested a review from a team April 15, 2024 21:28
@product-auto-label product-auto-label Bot added the api: cloudsql-mysql Issues related to the googleapis/langchain-google-cloud-sql-mysql-python API. label Apr 15, 2024
@averikitsch averikitsch merged commit 4832524 into main Apr 15, 2024
@averikitsch averikitsch deleted the jackwotherspoon-patch-1 branch April 15, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudsql-mysql Issues related to the googleapis/langchain-google-cloud-sql-mysql-python API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants