Conversation
jackwotherspoon
approved these changes
Feb 1, 2024
Contributor
jackwotherspoon
left a comment
There was a problem hiding this comment.
Overall LGTM, added one open question about argument naming
totoleon
added a commit
that referenced
this pull request
Feb 1, 2024
…#8) * feat: add MSSQLEngine and MSSQLLoader synced from the mysql code (#7) Sync code from langchain-google-cloud-sql-mysql-python with the following tuning changed driver to be pytds updated package names and file names changed from_instance to take username and password, because MSSQL doesn't support IAM auth for now removed the IAM auth and credential provider related code updated integration test to use MSSQL queries updated test assertion to match MSSQL data type updated the cloud build configuration updated Cloud Build configure to use secretEnv --------- Co-authored-by: Hailong Li <hailongli@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync code from langchain-google-cloud-sql-mysql-python with the following tuning