Gax has introduced FlowControl settings in [1] (see setFlowControlSettings). This makes it seem like Flow Control is available in the APIs that support BatchSettings, such as Pub/Sub's Publisher [2]. There are two issues here:
- FlowControlSettings settings in GAX have no way of communicating to the user whether a particular client implements them. This is actually true of all batching settings. This is a recipe for confusion.
- In the particular case of Pub/Sub client, publisher flow control is a desirable feature in itself. We either need to decide to implement it and turn this bug into a feature request and offer explicit failure and documentation if we decided not to.
[1] http://googleapis.github.io/gax-java/1.4.1/apidocs/com/google/api/gax/batching/BatchingSettings.Builder.html#setFlowControlSettings-com.google.api.gax.batching.FlowControlSettings-
[2] https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java#L124
Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Please run down the following list and make sure you've tried the usual "quick fixes":
If you are still having issues, please be sure to include as much information as possible:
Environment details
- Specify the API at the beginning of the title (for example, "BigQuery: ...")
General, Core, and Other are also allowed as types
- OS type and version:
- Java version:
- google-cloud-java version(s):
Steps to reproduce
- ?
- ?
Code example
Stack trace
Any relevant stacktrace here.
External references such as API reference guides used
Any additional information below
Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!
Gax has introduced FlowControl settings in [1] (see setFlowControlSettings). This makes it seem like Flow Control is available in the APIs that support BatchSettings, such as Pub/Sub's Publisher [2]. There are two issues here:
[1] http://googleapis.github.io/gax-java/1.4.1/apidocs/com/google/api/gax/batching/BatchingSettings.Builder.html#setFlowControlSettings-com.google.api.gax.batching.FlowControlSettings-
[2] https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java#L124
Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Please run down the following list and make sure you've tried the usual "quick fixes":
If you are still having issues, please be sure to include as much information as possible:
Environment details
General, Core, and Other are also allowed as types
Steps to reproduce
Code example
// exampleStack trace
External references such as API reference guides used
Any additional information below
Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!