Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

deps: test building with newer library version#453

Merged
gcf-merge-on-green[bot] merged 3 commits into
2.8.xfrom
2.8.x_patch
Oct 10, 2022
Merged

deps: test building with newer library version#453
gcf-merge-on-green[bot] merged 3 commits into
2.8.xfrom
2.8.x_patch

Conversation

@mpeddada1
Copy link
Copy Markdown

@mpeddada1 mpeddada1 commented Oct 10, 2022

'No need to review.'

@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Oct 10, 2022
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Oct 10, 2022

Warning: This pull request is touching the following templated files:

  • proto-google-common-protos/src/main/java/com/google/api/Advice.java
  • proto-google-common-protos/src/main/java/com/google/api/AuthProvider.java
  • proto-google-common-protos/src/main/java/com/google/api/AuthRequirement.java
  • proto-google-common-protos/src/main/java/com/google/api/Authentication.java
  • proto-google-common-protos/src/main/java/com/google/api/AuthenticationRule.java
  • proto-google-common-protos/src/main/java/com/google/api/Backend.java
  • proto-google-common-protos/src/main/java/com/google/api/BackendRule.java
  • proto-google-common-protos/src/main/java/com/google/api/Billing.java
  • proto-google-common-protos/src/main/java/com/google/api/ConfigChange.java
  • proto-google-common-protos/src/main/java/com/google/api/Context.java
  • proto-google-common-protos/src/main/java/com/google/api/ContextRule.java
  • proto-google-common-protos/src/main/java/com/google/api/Control.java
  • proto-google-common-protos/src/main/java/com/google/api/CustomHttpPattern.java
  • proto-google-common-protos/src/main/java/com/google/api/Distribution.java
  • proto-google-common-protos/src/main/java/com/google/api/Documentation.java
  • proto-google-common-protos/src/main/java/com/google/api/DocumentationRule.java
  • proto-google-common-protos/src/main/java/com/google/api/Endpoint.java
  • proto-google-common-protos/src/main/java/com/google/api/EndpointOrBuilder.java
  • proto-google-common-protos/src/main/java/com/google/api/Http.java
  • proto-google-common-protos/src/main/java/com/google/api/HttpBody.java
  • proto-google-common-protos/src/main/java/com/google/api/HttpRule.java
  • proto-google-common-protos/src/main/java/com/google/api/JwtLocation.java
  • proto-google-common-protos/src/main/java/com/google/api/LabelDescriptor.java
  • proto-google-common-protos/src/main/java/com/google/api/LogDescriptor.java
  • proto-google-common-protos/src/main/java/com/google/api/Logging.java
  • proto-google-common-protos/src/main/java/com/google/api/Metric.java
  • proto-google-common-protos/src/main/java/com/google/api/MetricDescriptor.java
  • proto-google-common-protos/src/main/java/com/google/api/MetricRule.java
  • proto-google-common-protos/src/main/java/com/google/api/MonitoredResource.java
  • proto-google-common-protos/src/main/java/com/google/api/MonitoredResourceDescriptor.java
  • proto-google-common-protos/src/main/java/com/google/api/MonitoredResourceMetadata.java
  • proto-google-common-protos/src/main/java/com/google/api/Monitoring.java
  • proto-google-common-protos/src/main/java/com/google/api/OAuthRequirements.java
  • proto-google-common-protos/src/main/java/com/google/api/Page.java
  • proto-google-common-protos/src/main/java/com/google/api/ProjectProperties.java
  • proto-google-common-protos/src/main/java/com/google/api/Property.java
  • proto-google-common-protos/src/main/java/com/google/api/Quota.java
  • proto-google-common-protos/src/main/java/com/google/api/QuotaLimit.java
  • proto-google-common-protos/src/main/java/com/google/api/ResourceDescriptor.java
  • proto-google-common-protos/src/main/java/com/google/api/ResourceReference.java
  • proto-google-common-protos/src/main/java/com/google/api/RoutingParameter.java
  • proto-google-common-protos/src/main/java/com/google/api/RoutingRule.java
  • proto-google-common-protos/src/main/java/com/google/api/Service.java
  • proto-google-common-protos/src/main/java/com/google/api/ServiceOrBuilder.java
  • proto-google-common-protos/src/main/java/com/google/api/SourceInfo.java
  • proto-google-common-protos/src/main/java/com/google/api/SystemParameter.java
  • proto-google-common-protos/src/main/java/com/google/api/SystemParameterRule.java
  • proto-google-common-protos/src/main/java/com/google/api/SystemParameters.java
  • proto-google-common-protos/src/main/java/com/google/api/Usage.java
  • proto-google-common-protos/src/main/java/com/google/api/UsageRule.java
  • proto-google-common-protos/src/main/java/com/google/api/Visibility.java
  • proto-google-common-protos/src/main/java/com/google/api/VisibilityRule.java
  • proto-google-common-protos/src/main/java/com/google/cloud/audit/AuditLog.java
  • proto-google-common-protos/src/main/java/com/google/cloud/audit/AuditLogOrBuilder.java
  • proto-google-common-protos/src/main/java/com/google/cloud/audit/AuthenticationInfo.java
  • proto-google-common-protos/src/main/java/com/google/cloud/audit/AuthorizationInfo.java
  • proto-google-common-protos/src/main/java/com/google/cloud/audit/RequestMetadata.java
  • proto-google-common-protos/src/main/java/com/google/cloud/audit/ResourceLocation.java
  • proto-google-common-protos/src/main/java/com/google/cloud/audit/ServiceAccountDelegationInfo.java
  • proto-google-common-protos/src/main/java/com/google/geo/type/Viewport.java
  • proto-google-common-protos/src/main/java/com/google/logging/type/HttpRequest.java
  • proto-google-common-protos/src/main/java/com/google/longrunning/CancelOperationRequest.java
  • proto-google-common-protos/src/main/java/com/google/longrunning/DeleteOperationRequest.java
  • proto-google-common-protos/src/main/java/com/google/longrunning/GetOperationRequest.java
  • proto-google-common-protos/src/main/java/com/google/longrunning/ListOperationsRequest.java
  • proto-google-common-protos/src/main/java/com/google/longrunning/ListOperationsResponse.java
  • proto-google-common-protos/src/main/java/com/google/longrunning/Operation.java
  • proto-google-common-protos/src/main/java/com/google/longrunning/OperationInfo.java
  • proto-google-common-protos/src/main/java/com/google/longrunning/WaitOperationRequest.java
  • proto-google-common-protos/src/main/java/com/google/rpc/BadRequest.java
  • proto-google-common-protos/src/main/java/com/google/rpc/DebugInfo.java
  • proto-google-common-protos/src/main/java/com/google/rpc/ErrorInfo.java
  • proto-google-common-protos/src/main/java/com/google/rpc/Help.java
  • proto-google-common-protos/src/main/java/com/google/rpc/LocalizedMessage.java
  • proto-google-common-protos/src/main/java/com/google/rpc/PreconditionFailure.java
  • proto-google-common-protos/src/main/java/com/google/rpc/QuotaFailure.java
  • proto-google-common-protos/src/main/java/com/google/rpc/RequestInfo.java
  • proto-google-common-protos/src/main/java/com/google/rpc/ResourceInfo.java
  • proto-google-common-protos/src/main/java/com/google/rpc/RetryInfo.java
  • proto-google-common-protos/src/main/java/com/google/rpc/Status.java
  • proto-google-common-protos/src/main/java/com/google/rpc/context/AttributeContext.java
  • proto-google-common-protos/src/main/java/com/google/type/Color.java
  • proto-google-common-protos/src/main/java/com/google/type/Date.java
  • proto-google-common-protos/src/main/java/com/google/type/DateTime.java
  • proto-google-common-protos/src/main/java/com/google/type/Decimal.java
  • proto-google-common-protos/src/main/java/com/google/type/Expr.java
  • proto-google-common-protos/src/main/java/com/google/type/Fraction.java
  • proto-google-common-protos/src/main/java/com/google/type/Interval.java
  • proto-google-common-protos/src/main/java/com/google/type/LatLng.java
  • proto-google-common-protos/src/main/java/com/google/type/LocalizedText.java
  • proto-google-common-protos/src/main/java/com/google/type/Money.java
  • proto-google-common-protos/src/main/java/com/google/type/PhoneNumber.java
  • proto-google-common-protos/src/main/java/com/google/type/PostalAddress.java
  • proto-google-common-protos/src/main/java/com/google/type/Quaternion.java
  • proto-google-common-protos/src/main/java/com/google/type/TimeOfDay.java
  • proto-google-common-protos/src/main/java/com/google/type/TimeZone.java

@suztomo
Copy link
Copy Markdown
Member

suztomo commented Oct 10, 2022

Good. It now shows methods available in protobuf runtime library version 3.19.6. Can you update the runtime library version?

[INFO] -------------------------------------------------------------
Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/java-common-protos/java-common-protos/proto-google-common-protos/src/main/java/com/google/api/Distribution.java:[535,29] cannot find symbol
  symbol: method parseUnknownField(com.google.protobuf.CodedInputStream,com.google.protobuf.ExtensionRegistryLite,int)
Error:  /home/runner/work/java-common-protos/java-common-protos/proto-google-common-protos/src/main/java/com/google/api/Distribution.java:[1415,31] cannot find symbol
  symbol: method parseUnknownField(com.google.protobuf.CodedInputStream,com.google.protobuf.ExtensionRegistryLite,int)
Error:  /home/runner/work/java-common-protos/java-common-protos/proto-google-common-protos/src/main/java/com/google/api/Distribution.java:[2176,31] cannot find symbol
  symbol: method parseUnknownField(com.google.protobuf.CodedInputStream,com.google.protobuf.ExtensionRegistryLite,int)
Error:  /home/runner/work/java-common-protos/java-common-protos/proto-google-common-protos/src/main/java/com/google/api/Distribution.java:[2923,31] cannot find symbol
  symbol: method parseUnknownField(com.google.protobuf.CodedInputStream,com.google.protobuf.ExtensionRegistryLite,int)

@suztomo suztomo marked this pull request as ready for review October 10, 2022 18:08
@suztomo suztomo requested a review from a team October 10, 2022 18:08
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2022
@suztomo suztomo added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 6800fd0 into 2.8.x Oct 10, 2022
@gcf-merge-on-green gcf-merge-on-green Bot deleted the 2.8.x_patch branch October 10, 2022 18:20
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 10, 2022
@release-please release-please Bot mentioned this pull request Oct 10, 2022
Merged
gcf-merge-on-green Bot pushed a commit that referenced this pull request Oct 10, 2022
@release-please
chore(2.8.x): release 2.8.4 (#454)
061a0ce 
🤖 I have created a release *beep* *boop*
---


## [2.8.4](https://togithub.com/googleapis/java-common-protos/compare/v2.8.3...v2.8.4) (2022-10-10)


### Dependencies

* Test building with newer library version ([#453](https://togithub.com/googleapis/java-common-protos/issues/453)) ([6800fd0](https://togithub.com/googleapis/java-common-protos/commit/6800fd01ac38d834ee94b167324e4e1d7b5530a4))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@suztomo suztomo suztomo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpeddada1 @suztomo