From c8607b98e5e87fb33db38b54f9bfabdb70d1b8f8 Mon Sep 17 00:00:00 2001
From: Mattie Fu <mattiefu@google.com>
Date: Wed, 14 Dec 2022 11:04:57 -0500
Subject: [PATCH 1/8] chore(doc): fix documentation on cloud.google.com to not
 show internal classes

---
 pom.xml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 6f0221a3d71c..67979102988c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -325,7 +325,8 @@
                                 -outputpath ${project.build.directory}/docfx-yml
                                 -projectname ${artifactId}
                                 <!-- List of excluded packages as regex, separated by a colon-->
-                                -excludeclasses com\.google\.cloud\.bigtable\.admin\.v2\.internal\.:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableInstanceAdminClient:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableInstanceAdminSettings:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableInstanceAdminCallableFactory:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableInstanceAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.BigtableInstanceAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableTableAdminClient:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableTableAdminSettings:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableTableAdminCallableFactory:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableTableAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.BigtableTableAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.EnhancedBigtableTableAdminStub:com\.google\.cloud\.bigtable\.data\.v2\.internal\.:com\.google\.cloud\.bigtable\.data\.v2\.BaseBigtableDataClient:com\.google\.cloud\.bigtable\.data\.v2\.BaseBigtableDataSettings:com\.google\.cloud\.bigtable\.data\.v2\.stub\.BigtableStub:com\.google\.cloud\.bigtable\.data\.v2\.stub\.BigtableStubSettings:com\.google\.cloud\.bigtable\.data\.v2\.stub\.GrpcBigtableStub:com\.google\.cloud\.bigtable\.data\.v2\.stub\.GrpcBigtableCallableFactory:com\.google\.cloud\.bigtable\.data\.v2\.stub\.EnhancedBigtableStub:com\.google\.cloud\.bigtable\.data\.v2\.stub\.mutaterows\.:com\.google\.cloud\.bigtable\.data\.v2\.stub\.readrows\.:com\.google\.cloud\.bigtable\.data\.v2\.stub\.metrics\.
+                                -excludeclasses com\.google\.cloud\.bigtable\.admin\.v2\.internal\.:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableInstanceAdminClient:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableInstanceAdminSettings:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableInstanceAdminCallableFactory:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableInstanceAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.BigtableInstanceAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableTableAdminClient:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableTableAdminSettings:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableTableAdminCallableFactory:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableTableAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.BigtableTableAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.EnhancedBigtableTableAdminStub:com\.google\.cloud\.bigtable\.data\.v2\.internal\.:com\.google\.cloud\.bigtable\.data\.v2\.BaseBigtableDataClient:com\.google\.cloud\.bigtable\.data\.v2\.BaseBigtableDataSettings:com\.google\.cloud\.bigtable\.data\.v2\.stub\.BigtableStub:com\.google\.cloud\.bigtable\.data\.v2\.stub\.BigtableStubSettings:com\.google\.cloud\.bigtable\.data\.v2\.stub\.GrpcBigtableStub:com\.google\.cloud\.bigtable\.data\.v2\.stub\.GrpcBigtableCallableFactory:com\.google\.cloud\.bigtable\.data\.v2\.stub\.SafeResponseObserver:com\.google\.cloud\.bigtable\.data\.v2\.stub\.EnhancedBigtableStub:com\.google\.cloud\.bigtable\.data\.v2\.stub\.mutaterows\.:com\.google\.cloud\.bigtable\.data\.v2\.stub\.readrows\.:com\.google\.cloud\.bigtable\.data\.v2\.stub\.metrics\.
+                                -excludepackages com\.google\.bigtable\.v2:com\.google\.bigtable\.admin\.v2:com\.google\.cloud\.bigtable\.stats
                             </additionalOptions>
                         </configuration>
                         <executions>

From 15b5403abcfe0836ea7d16b538d13ef4d45b5180 Mon Sep 17 00:00:00 2001
From: Mattie Fu <mattiefu@google.com>
Date: Wed, 14 Dec 2022 14:37:21 -0500
Subject: [PATCH 2/8] update

---
 pom.xml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 67979102988c..3a60f5170699 100644
--- a/pom.xml
+++ b/pom.xml
@@ -325,10 +325,11 @@
                                 -outputpath ${project.build.directory}/docfx-yml
                                 -projectname ${artifactId}
                                 <!-- List of excluded packages as regex, separated by a colon-->
-                                -excludeclasses com\.google\.cloud\.bigtable\.admin\.v2\.internal\.:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableInstanceAdminClient:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableInstanceAdminSettings:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableInstanceAdminCallableFactory:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableInstanceAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.BigtableInstanceAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableTableAdminClient:com\.google\.cloud\.bigtable\.admin\.v2\.BaseBigtableTableAdminSettings:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableTableAdminCallableFactory:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.GrpcBigtableTableAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.BigtableTableAdminStub:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.EnhancedBigtableTableAdminStub:com\.google\.cloud\.bigtable\.data\.v2\.internal\.:com\.google\.cloud\.bigtable\.data\.v2\.BaseBigtableDataClient:com\.google\.cloud\.bigtable\.data\.v2\.BaseBigtableDataSettings:com\.google\.cloud\.bigtable\.data\.v2\.stub\.BigtableStub:com\.google\.cloud\.bigtable\.data\.v2\.stub\.BigtableStubSettings:com\.google\.cloud\.bigtable\.data\.v2\.stub\.GrpcBigtableStub:com\.google\.cloud\.bigtable\.data\.v2\.stub\.GrpcBigtableCallableFactory:com\.google\.cloud\.bigtable\.data\.v2\.stub\.SafeResponseObserver:com\.google\.cloud\.bigtable\.data\.v2\.stub\.EnhancedBigtableStub:com\.google\.cloud\.bigtable\.data\.v2\.stub\.mutaterows\.:com\.google\.cloud\.bigtable\.data\.v2\.stub\.readrows\.:com\.google\.cloud\.bigtable\.data\.v2\.stub\.metrics\.
+                                -excludeclasses com\.google\.cloud\.bigtable\.admin\.v2\.internal\.:com\.google\.cloud\.bigtable\.admin\.v2\.(Base.*).*:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.(?!Bigtable.*StubSettings).*:com\.google\.cloud\.bigtable\.data\.v2\.internal\.:com\.google\.cloud\.bigtable\.data\.v2\.(Base.*).*:com\.google\.cloud\.bigtable\.data\.v2\.stub\.(?!Enhanced.*StubSettings).*:com\.google\.cloud\.bigtable\.data\.v2\.stub\.mutaterows\.:com\.google\.cloud\.bigtable\.data\.v2\.stub\.readrows\.:com\.google\.cloud\.bigtable\.data\.v2\.stub\.metrics\.
                                 -excludepackages com\.google\.bigtable\.v2:com\.google\.bigtable\.admin\.v2:com\.google\.cloud\.bigtable\.stats
                             </additionalOptions>
                         </configuration>
+                        
                         <executions>
                             <execution>
                                 <id>aggregate</id>

From aa7e090fd3a8e1e8305b2feb9a28736c832231f6 Mon Sep 17 00:00:00 2001
From: Mattie Fu <mattiefu@google.com>
Date: Wed, 14 Dec 2022 14:50:04 -0500
Subject: [PATCH 3/8] clean up

---
 pom.xml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/pom.xml b/pom.xml
index 3a60f5170699..552c72b0cdce 100644
--- a/pom.xml
+++ b/pom.xml
@@ -320,16 +320,17 @@
                         <configuration>
                             <doclet>com.microsoft.doclet.DocFxDoclet</doclet>
                             <useStandardDocletOptions>false</useStandardDocletOptions>
-                            <docletPath>${env.KOKORO_GFILE_DIR}/java-docfx-doclet-1.5.0.jar</docletPath>
+<!--                            <docletPath>${env.KOKORO_GFILE_DIR}/java-docfx-doclet-1.5.0.jar</docletPath>-->
+                            <docletPath>/Users/mattiefu/Downloads/docfx-doclet-1.8.0-jar-with-dependencies.jar</docletPath>
                             <additionalOptions>
                                 -outputpath ${project.build.directory}/docfx-yml
                                 -projectname ${artifactId}
                                 <!-- List of excluded packages as regex, separated by a colon-->
-                                -excludeclasses com\.google\.cloud\.bigtable\.admin\.v2\.internal\.:com\.google\.cloud\.bigtable\.admin\.v2\.(Base.*).*:com\.google\.cloud\.bigtable\.admin\.v2\.stub\.(?!Bigtable.*StubSettings).*:com\.google\.cloud\.bigtable\.data\.v2\.internal\.:com\.google\.cloud\.bigtable\.data\.v2\.(Base.*).*:com\.google\.cloud\.bigtable\.data\.v2\.stub\.(?!Enhanced.*StubSettings).*:com\.google\.cloud\.bigtable\.data\.v2\.stub\.mutaterows\.:com\.google\.cloud\.bigtable\.data\.v2\.stub\.readrows\.:com\.google\.cloud\.bigtable\.data\.v2\.stub\.metrics\.
-                                -excludepackages com\.google\.bigtable\.v2:com\.google\.bigtable\.admin\.v2:com\.google\.cloud\.bigtable\.stats
+                                -excludeclasses com\.google\.cloud\.bigtable\.admin\.v2\.(internal\.|(Base.*).*|stub\.(?!Bigtable.*StubSettings).*):com\.google\.cloud\.bigtable\.data\.v2\.(internal\.|(Base.*).*|stub\.(mutaterows\.|readrows\.|metrics\.|(?!Enhanced.*StubSettings).*))
+                                -excludepackages com\.google\.(bigtable\.v2|bigtable\.admin\.v2|cloud\.bigtable\.stats)
                             </additionalOptions>
                         </configuration>
-                        
+
                         <executions>
                             <execution>
                                 <id>aggregate</id>

From 616c93dd2a9b0f3f0be542eeb426b2f0cfdd3dea Mon Sep 17 00:00:00 2001
From: Mattie Fu <mattiefu@google.com>
Date: Wed, 14 Dec 2022 14:53:17 -0500
Subject: [PATCH 4/8] fix path

---
 pom.xml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 552c72b0cdce..4509326af3ed 100644
--- a/pom.xml
+++ b/pom.xml
@@ -320,8 +320,7 @@
                         <configuration>
                             <doclet>com.microsoft.doclet.DocFxDoclet</doclet>
                             <useStandardDocletOptions>false</useStandardDocletOptions>
-<!--                            <docletPath>${env.KOKORO_GFILE_DIR}/java-docfx-doclet-1.5.0.jar</docletPath>-->
-                            <docletPath>/Users/mattiefu/Downloads/docfx-doclet-1.8.0-jar-with-dependencies.jar</docletPath>
+                            <docletPath>${env.KOKORO_GFILE_DIR}/java-docfx-doclet-1.5.0.jar</docletPath>
                             <additionalOptions>
                                 -outputpath ${project.build.directory}/docfx-yml
                                 -projectname ${artifactId}

From 5d8d81045366b1620189a47977ac38c0a76c959a Mon Sep 17 00:00:00 2001
From: Mattie Fu <mattiefu@google.com>
Date: Wed, 14 Dec 2022 15:09:05 -0500
Subject: [PATCH 5/8] add some comments

---
 pom.xml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/pom.xml b/pom.xml
index 4509326af3ed..bbce755c91e2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -245,6 +245,7 @@
                 </executions>
 
                 <configuration>
+                    <!-- This is the old way of publishing the doc to googleapis.dev -->
                     <doclint>none</doclint>
                     <show>protected</show>
                     <nohelp>true</nohelp>
@@ -318,6 +319,7 @@
                         <artifactId>maven-javadoc-plugin</artifactId>
                         <version>3.4.1</version>
                         <configuration>
+                            <!-- This is the new way of publishing the doc to cloud.google.com -->
                             <doclet>com.microsoft.doclet.DocFxDoclet</doclet>
                             <useStandardDocletOptions>false</useStandardDocletOptions>
                             <docletPath>${env.KOKORO_GFILE_DIR}/java-docfx-doclet-1.5.0.jar</docletPath>

From efa0bb72e3714d96156471604d0967fe4162d2b8 Mon Sep 17 00:00:00 2001
From: Mattie Fu <mattiefu@google.com>
Date: Wed, 14 Dec 2022 15:18:06 -0500
Subject: [PATCH 6/8] clean up more

---
 pom.xml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index bbce755c91e2..77adfb81cda0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -322,12 +322,15 @@
                             <!-- This is the new way of publishing the doc to cloud.google.com -->
                             <doclet>com.microsoft.doclet.DocFxDoclet</doclet>
                             <useStandardDocletOptions>false</useStandardDocletOptions>
-                            <docletPath>${env.KOKORO_GFILE_DIR}/java-docfx-doclet-1.5.0.jar</docletPath>
+<!--                            <docletPath>${env.KOKORO_GFILE_DIR}/java-docfx-doclet-1.5.0.jar</docletPath>-->
+                            <docletPath>/Users/mattiefu/Downloads/docfx-doclet-1.8.0-jar-with-dependencies.jar</docletPath>
                             <additionalOptions>
                                 -outputpath ${project.build.directory}/docfx-yml
                                 -projectname ${artifactId}
                                 <!-- List of excluded packages as regex, separated by a colon-->
-                                -excludeclasses com\.google\.cloud\.bigtable\.admin\.v2\.(internal\.|(Base.*).*|stub\.(?!Bigtable.*StubSettings).*):com\.google\.cloud\.bigtable\.data\.v2\.(internal\.|(Base.*).*|stub\.(mutaterows\.|readrows\.|metrics\.|(?!Enhanced.*StubSettings).*))
+                                <!-- exclude all internal classes in admin and data and everything under stub/ except for the StubSettings -->
+                                -excludeclasses com\.google\.cloud\.bigtable\.admin\.v2\.(internal\.|(Base.*).*|stub\.(?!Bigtable.*StubSettings).*):com\.google\.cloud\.bigtable\.data\.v2\.(internal\.|(Base.*).*|stub\.(?!Enhanced.*StubSettings).*)
+                                <!-- exclude all auto-generated files from protos and the stats package -->
                                 -excludepackages com\.google\.(bigtable\.v2|bigtable\.admin\.v2|cloud\.bigtable\.stats)
                             </additionalOptions>
                         </configuration>

From b236c01816f6a66378c3a65af420c296573c922f Mon Sep 17 00:00:00 2001
From: Mattie Fu <mattiefu@google.com>
Date: Wed, 14 Dec 2022 16:16:00 -0500
Subject: [PATCH 7/8] update comment

---
 pom.xml | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/pom.xml b/pom.xml
index 77adfb81cda0..c5e81e1b07f1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -322,15 +322,19 @@
                             <!-- This is the new way of publishing the doc to cloud.google.com -->
                             <doclet>com.microsoft.doclet.DocFxDoclet</doclet>
                             <useStandardDocletOptions>false</useStandardDocletOptions>
-<!--                            <docletPath>${env.KOKORO_GFILE_DIR}/java-docfx-doclet-1.5.0.jar</docletPath>-->
-                            <docletPath>/Users/mattiefu/Downloads/docfx-doclet-1.8.0-jar-with-dependencies.jar</docletPath>
+                            <docletPath>${env.KOKORO_GFILE_DIR}/java-docfx-doclet-1.5.0.jar</docletPath>
                             <additionalOptions>
                                 -outputpath ${project.build.directory}/docfx-yml
                                 -projectname ${artifactId}
                                 <!-- List of excluded packages as regex, separated by a colon-->
-                                <!-- exclude all internal classes in admin and data and everything under stub/ except for the StubSettings -->
+                                <!-- Exclude generating javadocs for internal implementations for admin and data, which
+                                 are under internal/ and .v2.stub/, and exclude all BaseClients and BaseSettings.
+                                 The only exception is we want to keep the javadoc for StubSettings. -->
                                 -excludeclasses com\.google\.cloud\.bigtable\.admin\.v2\.(internal\.|(Base.*).*|stub\.(?!Bigtable.*StubSettings).*):com\.google\.cloud\.bigtable\.data\.v2\.(internal\.|(Base.*).*|stub\.(?!Enhanced.*StubSettings).*)
-                                <!-- exclude all auto-generated files from protos and the stats package -->
+                                <!-- Exclude the javadocs for the auto-generated raw protos since we don't expose them.
+                                 The raw protos generated by gapic are under com.google.bigtable. And the public surface
+                                 is under com.google.cloud.bigtable. Also exclude the stats package which is the
+                                 internal implementation for metrics. -->
                                 -excludepackages com\.google\.(bigtable\.v2|bigtable\.admin\.v2|cloud\.bigtable\.stats)
                             </additionalOptions>
                         </configuration>

From db824c921d4fe551f669c1793c21c8bbabd1c990 Mon Sep 17 00:00:00 2001
From: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Date: Wed, 14 Dec 2022 21:27:49 +0000
Subject: [PATCH 8/8] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20po?=
 =?UTF-8?q?st-processor?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---
 README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index be062c7f2660..35257d287b7e 100644
--- a/README.md
+++ b/README.md
@@ -56,13 +56,13 @@ implementation 'com.google.cloud:google-cloud-bigtable'
 If you are using Gradle without BOM, add this to your dependencies:
 
 ```Groovy
-implementation 'com.google.cloud:google-cloud-bigtable:2.17.0'
+implementation 'com.google.cloud:google-cloud-bigtable:2.17.1'
 ```
 
 If you are using SBT, add this to your dependencies:
 
 ```Scala
-libraryDependencies += "com.google.cloud" % "google-cloud-bigtable" % "2.17.0"
+libraryDependencies += "com.google.cloud" % "google-cloud-bigtable" % "2.17.1"
 ```
 
 ## Authentication