feat(bigtable): classic direct access checker and it's implementation#2840

Merged

gcf-merge-on-green[bot] merged 28 commits intomainfrom

Mar 31, 2026

Contributor

sushanb commented Mar 12, 2026

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Rollback plan is reviewed and LGTMed
All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

sushanb requested a review from igorbernstein2

March 12, 2026 16:03

sushanb requested review from a team as code owners

March 12, 2026 16:03

product-auto-label bot added size: l api: bigtable labels

igorbernstein2 reviewed

View reviewed changes

...cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/MetricsImpl.java Outdated Show resolved Hide resolved

igorbernstein2 reviewed

View reviewed changes

...cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/DirectAccessChecker.java Outdated Show resolved Hide resolved

igorbernstein2 reviewed

View reviewed changes

...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java Outdated Show resolved Hide resolved

igorbernstein2 reviewed

View reviewed changes

...-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/UnaryDirectAccessChecker.java Outdated Show resolved Hide resolved

igorbernstein2 reviewed

View reviewed changes

...ud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelFactory.java Outdated Show resolved Hide resolved

igorbernstein2 reviewed

View reviewed changes

...-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/UnaryDirectAccessChecker.java Outdated Show resolved Hide resolved

sushanb added 6 commits

March 20, 2026 23:32


          int commit

bf0003b

fix

a6910b2

fix

60bc8f4

fix

547f461

fix

30c17d5


          address review comments

f69837e

sushanb force-pushed the dp_check branch from c9af4b1 to f69837e Compare

March 21, 2026 04:26


          address review comments

1ca692c

sushanb requested a review from igorbernstein2

March 21, 2026 04:28

sushanb added 2 commits

March 21, 2026 00:48


          address review comments

cc306bc

fix

d8cf0e8

sushanb changed the title ~~feat(bigtable): unary direct access checker and it's implementation~~ feat(bigtable): classic direct access checker and it's implementation

sushanb added 2 commits

March 23, 2026 16:54


          comments

819444e

fix

ceaea99

sushanb requested a review from nimf

March 23, 2026 20:59

sushanb added 2 commits

March 24, 2026 01:31


          no nullable

23fbcd2


          no nullable

04ea584

nimf reviewed

View reviewed changes

Contributor

nimf left a comment

First comments from the first pass. Will do another pass soon.

...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java Show resolved Hide resolved

...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java Outdated Show resolved Hide resolved

fix

209b606

sushanb requested a review from igorbernstein2

March 29, 2026 20:41

fix

sushanb force-pushed the dp_check branch from ecb59d8 to 7290306 Compare

March 30, 2026 15:38

product-auto-label bot added size: l and removed size: xl labels

igorbernstein2 requested changes

View reviewed changes

.../src/main/java/com/google/cloud/bigtable/data/v2/internal/dp/ClassicDirectAccessChecker.java Show resolved Hide resolved

...a/com/google/cloud/bigtable/data/v2/internal/csm/tracers/DirectPathCompatibleTracerImpl.java Outdated Show resolved Hide resolved

...le/src/main/java/com/google/cloud/bigtable/data/v2/internal/dp/DirectAccessInvestigator.java Outdated Show resolved Hide resolved

...le/src/main/java/com/google/cloud/bigtable/data/v2/internal/dp/DirectAccessInvestigator.java Outdated Show resolved Hide resolved

...le/src/main/java/com/google/cloud/bigtable/data/v2/internal/dp/DirectAccessInvestigator.java Show resolved Hide resolved

...d-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelSupplier.java Outdated Show resolved Hide resolved

...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated Show resolved Hide resolved

sushanb added 2 commits

March 30, 2026 12:56

fix

7f83e59

fix

c3ab878

sushanb requested a review from igorbernstein2

March 30, 2026 18:50

igorbernstein2 requested changes

View reviewed changes

...a/com/google/cloud/bigtable/data/v2/internal/csm/tracers/DirectPathCompatibleTracerImpl.java Outdated Show resolved Hide resolved

...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated Show resolved Hide resolved

...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated Show resolved Hide resolved

sushanb added 2 commits

March 31, 2026 11:46

fix

4f4b430


          todo

a46b61a

sushanb requested a review from igorbernstein2

March 31, 2026 17:16

sushanb added 3 commits

March 31, 2026 15:19

fix

0ab3a4c

add

8684bb4

wip

c1e2485

sushanb force-pushed the dp_check branch from 23a7e6c to c1e2485 Compare

March 31, 2026 21:02

igorbernstein2 approved these changes

View reviewed changes

igorbernstein2 added automerge and removed automerge labels

nimf reviewed

View reviewed changes

...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Show resolved Hide resolved

igorbernstein2 added automerge and removed automerge labels

fix

e8d5c21

sushanb added the automerge label

gcf-merge-on-green bot merged commit c2ccda1 into main

27 of 28 checks passed

gcf-merge-on-green bot removed the automerge label

gcf-merge-on-green bot deleted the dp_check branch

March 31, 2026 23:20

release-please bot mentioned this pull request

chore(main): release 2.76.0 #2856

Open

nimf reviewed

View reviewed changes

...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java

+                    GrpcTransportChannel grpcTransportChannel =
+                        (GrpcTransportChannel) directAccessProvider.getTransportChannel();
+                    ManagedChannel directAccessChannel = (ManagedChannel) grpcTransportChannel.getChannel();
+                    isDirectAccessEligible = directAccessChecker.check(directAccessChannel);

Contributor

nimf Apr 1, 2026

if check returned false we need to call investigateFailure right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable size: l