Skip to content

Commit e841b54

Browse files
committed
chore: follow error prone suggestion (non-nullable return value)
1 parent acbd523 commit e841b54

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/changestream/ReadChangeStreamMergingAcceptanceTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,14 +285,14 @@ public void test() throws Exception {
285285

286286
private static boolean expectsError(ReadChangeStreamTest testCase) {
287287
List<ReadChangeStreamTest.Result> results = testCase.getResultsList();
288-
return results != null && !results.isEmpty() && results.get(results.size() - 1).getError();
288+
return !results.isEmpty() && !results.isEmpty() && results.get(results.size() - 1).getError();
289289
}
290290

291291
private static List<ReadChangeStreamTest.Result> getNonExceptionResults(
292292
ReadChangeStreamTest testCase) {
293293
List<ReadChangeStreamTest.Result> results = testCase.getResultsList();
294294
List<ReadChangeStreamTest.Result> response = new ArrayList<>();
295-
if (results != null) {
295+
if (!results.isEmpty()) {
296296
for (ReadChangeStreamTest.Result result : results) {
297297
if (!result.getError()) {
298298
response.add(result);

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,14 +142,14 @@ public void test() throws Exception {
142142

143143
private static boolean expectsError(ReadRowsTest rrt) {
144144
List<ReadRowsTest.Result> results = rrt.getResultsList();
145-
return results != null && !results.isEmpty() && results.get(results.size() - 1).getError();
145+
return !results.isEmpty() && !results.isEmpty() && results.get(results.size() - 1).getError();
146146
}
147147

148148
private static List<ReadRowsTest.Result> getNonExceptionResults(ReadRowsTest rrt) {
149149
List<ReadRowsTest.Result> results = rrt.getResultsList();
150150

151151
List<ReadRowsTest.Result> response = new ArrayList<>();
152-
if (results != null) {
152+
if (!results.isEmpty()) {
153153
for (ReadRowsTest.Result result : results) {
154154
if (!result.getError()) {
155155
response.add(result);

0 commit comments

Comments
 (0)