This repository was archived by the owner on Feb 24, 2026. It is now read-only.
feat: enable hermetic library generation#2515
Merged
diegomarquezp merged 13 commits intogoogleapis:mainfrom Jun 30, 2024
Merged
feat: enable hermetic library generation#2515diegomarquezp merged 13 commits intogoogleapis:mainfrom
diegomarquezp merged 13 commits intogoogleapis:mainfrom
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
|
Warning: This pull request is touching the following templated files:
|
c0979c0 to
cec5749
Compare
blakeli0
reviewed
Jun 20, 2024
blakeli0
reviewed
Jun 20, 2024
PhongChuong
approved these changes
Jun 21, 2024
blakeli0
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the effort to enable multi-version support in hand-written libraries. More context and details in this doc.
This PR adds two workflows and their scripts:
update_generation_configwhich updatesgeneration_config.yaml(added in this PR) to contain the latestgoogleapis_committish(source of truth of library generation) as well as other dependencies such asgapic_generator_version. This job runs nightly and creates a PR that modifies the config yaml.hermetic_library_generationwhich readsgeneration_config.yamland pushes a new commit to any PR whose latest commit affectsgeneration_config.yaml(e.g. the nightly PR created byupdate_generation_config). It essentially translates changes in the config yaml to changes in the source code (of the generated part). This workflow will be a required check.As an example of how they work in practice:
update_generation_configcreates a PR that updatesgeneration_config.yamlwith the latest dependencies and googleapis committishhermetic_library_generationis triggered by this PR and generates the corresponding code changes. A new commit with the code changes is added to the PR. This step may occur for any PR affectinggeneration_config.yaml.Follow ups
CLOUD_JAVA_BOT_TOKENto repository for the hermetic generation workflow to work