fix: update apimaxrequestbytes to be the accurate 20mb (#3099)

yirutang · cloud-java-bot · web-flow · commit 00b465b8f142 · 2025-10-06T14:20:45.000-07:00
* Update ApiMaxRequestBytes to be the accurate 20MB

* Fix test

* chore: generate libraries at Mon Oct  6 18:46:51 UTC 2025

* Add back getApiMaxRequestBytes on StreamWriter.

---------

Co-authored-by: cloud-java-bot &lt;cloud-java-bot@google.com&gt;
diff --git a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java
@@ -271,7 +271,7 @@ public static Boolean isDefaultStreamName(String streamName) {
 
   /** The maximum size of one request. Defined by the API. */
   public static long getApiMaxRequestBytes() {
-    return 20L * 1000L * 1000L; // 20 megabytes (https://en.wikipedia.org/wiki/Megabyte)
+    return 20L * (1L << 20); // 20 megabytes (https://en.wikipedia.org/wiki/Megabyte)
   }
 
   static String extractProjectName(String streamName) {
diff --git a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java
@@ -141,7 +141,7 @@ public class StreamWriter implements AutoCloseable {
 
   /** The maximum size of one request. Defined by the API. */
   public static long getApiMaxRequestBytes() {
-    return 10L * 1000L * 1000L; // 10 megabytes (https://en.wikipedia.org/wiki/Megabyte)
+    return ConnectionWorker.getApiMaxRequestBytes();
   }
 
   /**
diff --git a/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/StreamWriterTest.java b/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/StreamWriterTest.java
@@ -1408,7 +1408,8 @@ public void testMessageTooLarge() throws Exception {
     StreamWriter writer = getTestStreamWriter();
 
     // There is an oppotunity to allow 20MB requests.
-    String oversized = Strings.repeat("a", (int) (StreamWriter.getApiMaxRequestBytes() * 2 + 1));
+    String oversized =
+        Strings.repeat("a", (int) (ConnectionWorker.getApiMaxRequestBytes() * 2 + 1));
     ApiFuture<AppendRowsResponse> appendFuture1 = sendTestMessage(writer, new String[] {oversized});
     assertTrue(appendFuture1.isDone());
     StatusRuntimeException actualError =

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ public static Boolean isDefaultStreamName(String streamName) {`
`271`	`271`
`272`	`272`	`/** The maximum size of one request. Defined by the API. */`
`273`	`273`	`public static long getApiMaxRequestBytes() {`
`274`		`- return 20L * 1000L * 1000L; // 20 megabytes (https://en.wikipedia.org/wiki/Megabyte)`
	`274`	`+ return 20L * (1L << 20); // 20 megabytes (https://en.wikipedia.org/wiki/Megabyte)`
`275`	`275`	`}`
`276`	`276`
`277`	`277`	`static String extractProjectName(String streamName) {`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ public class StreamWriter implements AutoCloseable {`
`141`	`141`
`142`	`142`	`/** The maximum size of one request. Defined by the API. */`
`143`	`143`	`public static long getApiMaxRequestBytes() {`
`144`		`- return 10L * 1000L * 1000L; // 10 megabytes (https://en.wikipedia.org/wiki/Megabyte)`
	`144`	`+ return ConnectionWorker.getApiMaxRequestBytes();`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`/**`