Skip to content

Commit e26e183

Browse files
Google APIscopybara-github
authored andcommitted
fix: add resource config to scc/v1beta1/Asset
chore: update various comments PiperOrigin-RevId: 322867095
1 parent 3dfb55c commit e26e183

8 files changed

Lines changed: 55 additions & 55 deletions

File tree

google/cloud/securitycenter/v1beta1/asset.proto

Lines changed: 25 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2019 Google LLC.
1+
// Copyright 2020 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -11,13 +11,13 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
//
1514

1615
syntax = "proto3";
1716

1817
package google.cloud.securitycenter.v1beta1;
1918

2019
import "google/api/field_behavior.proto";
20+
import "google/api/resource.proto";
2121
import "google/cloud/securitycenter/v1beta1/security_marks.proto";
2222
import "google/protobuf/struct.proto";
2323
import "google/protobuf/timestamp.proto";
@@ -27,25 +27,31 @@ option go_package = "google.golang.org/genproto/googleapis/cloud/securitycenter/
2727
option java_multiple_files = true;
2828
option java_package = "com.google.cloud.securitycenter.v1beta1";
2929

30-
// Cloud Security Command Center's (Cloud SCC) representation of a Google Cloud
31-
// Platform (GCP) resource.
30+
// Security Command Center representation of a Google Cloud
31+
// resource.
3232
//
33-
// The Asset is a Cloud SCC resource that captures information about a single
34-
// GCP resource. All modifications to an Asset are only within the context of
35-
// Cloud SCC and don't affect the referenced GCP resource.
33+
// The Asset is a Security Command Center resource that captures information
34+
// about a single Google Cloud resource. All modifications to an Asset are only
35+
// within the context of Security Command Center and don't affect the referenced
36+
// Google Cloud resource.
3637
message Asset {
37-
// Cloud SCC managed properties. These properties are managed by Cloud SCC and
38-
// cannot be modified by the user.
38+
option (google.api.resource) = {
39+
type: "securitycenter.googleapis.com/Asset"
40+
pattern: "organizations/{organization}/assets/{asset}"
41+
};
42+
43+
// Security Command Center managed properties. These properties are managed by
44+
// Security Command Center and cannot be modified by the user.
3945
message SecurityCenterProperties {
40-
// Immutable. The full resource name of the GCP resource this asset
46+
// Immutable. The full resource name of the Google Cloud resource this asset
4147
// represents. This field is immutable after create time. See:
4248
// https://cloud.google.com/apis/design/resource_names#full_resource_name
4349
string resource_name = 1 [(google.api.field_behavior) = IMMUTABLE];
4450

45-
// The type of the GCP resource. Examples include: APPLICATION,
51+
// The type of the Google Cloud resource. Examples include: APPLICATION,
4652
// PROJECT, and ORGANIZATION. This is a case insensitive field defined by
47-
// Cloud SCC and/or the producer of the resource and is immutable
48-
// after create time.
53+
// Security Command Center and/or the producer of the resource and is
54+
// immutable after create time.
4955
string resource_type = 2;
5056

5157
// The full resource name of the immediate parent of the resource. See:
@@ -66,22 +72,22 @@ message Asset {
6672
// "organizations/{organization_id}/assets/{asset_id}".
6773
string name = 1;
6874

69-
// Cloud SCC managed properties. These properties are managed by
70-
// Cloud SCC and cannot be modified by the user.
75+
// Security Command Center managed properties. These properties are managed by
76+
// Security Command Center and cannot be modified by the user.
7177
SecurityCenterProperties security_center_properties = 2;
7278

7379
// Resource managed properties. These properties are managed and defined by
74-
// the GCP resource and cannot be modified by the user.
80+
// the Google Cloud resource and cannot be modified by the user.
7581
map<string, google.protobuf.Value> resource_properties = 7;
7682

7783
// User specified security marks. These marks are entirely managed by the user
7884
// and come from the SecurityMarks resource that belongs to the asset.
7985
SecurityMarks security_marks = 8;
8086

81-
// The time at which the asset was created in Cloud SCC.
87+
// The time at which the asset was created in Security Command Center.
8288
google.protobuf.Timestamp create_time = 9;
8389

84-
// The time at which the asset was last updated, added, or deleted in Cloud
85-
// SCC.
90+
// The time at which the asset was last updated, added, or deleted in Security
91+
// Command Center.
8692
google.protobuf.Timestamp update_time = 10;
8793
}

google/cloud/securitycenter/v1beta1/finding.proto

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2019 Google LLC.
1+
// Copyright 2020 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
//
1514

1615
syntax = "proto3";
1716

@@ -28,12 +27,12 @@ option go_package = "google.golang.org/genproto/googleapis/cloud/securitycenter/
2827
option java_multiple_files = true;
2928
option java_package = "com.google.cloud.securitycenter.v1beta1";
3029

31-
// Cloud Security Command Center (Cloud SCC) finding.
30+
// Security Command Center finding.
3231
//
3332
// A finding is a record of assessment data (security, risk, health or privacy)
34-
// ingested into Cloud SCC for presentation, notification, analysis,
35-
// policy testing, and enforcement. For example, an XSS vulnerability in an
36-
// App Engine application is a finding.
33+
// ingested into Security Command Center for presentation, notification,
34+
// analysis, policy testing, and enforcement. For example, an XSS vulnerability
35+
// in an App Engine application is a finding.
3736
message Finding {
3837
option (google.api.resource) = {
3938
type: "securitycenter.googleapis.com/Finding"
@@ -66,12 +65,12 @@ message Finding {
6665
// "organizations/{organization_id}/sources/{source_id}"
6766
string parent = 2 [(google.api.field_behavior) = IMMUTABLE];
6867

69-
// For findings on Google Cloud Platform (GCP) resources, the full resource
70-
// name of the GCP resource this finding is for. See:
68+
// For findings on Google Cloud resources, the full resource
69+
// name of the Google Cloud resource this finding is for. See:
7170
// https://cloud.google.com/apis/design/resource_names#full_resource_name
72-
// When the finding is for a non-GCP resource, the resourceName can be a
73-
// customer or partner defined string.
74-
// This field is immutable after creation time.
71+
// When the finding is for a non-Google Cloud resource, the resourceName can
72+
// be a customer or partner defined string. This field is immutable after
73+
// creation time.
7574
string resource_name = 3;
7675

7776
// The state of the finding.
@@ -82,9 +81,9 @@ message Finding {
8281
// Example: "XSS_FLASH_INJECTION"
8382
string category = 5;
8483

85-
// The URI that, if available, points to a web page outside of Cloud SCC
86-
// where additional information about the finding can be found. This field is
87-
// guaranteed to be either empty or a well formed URL.
84+
// The URI that, if available, points to a web page outside of Security
85+
// Command Center where additional information about the finding can be found.
86+
// This field is guaranteed to be either empty or a well formed URL.
8887
string external_uri = 6;
8988

9089
// Source specific properties. These properties are managed by the source
@@ -103,6 +102,6 @@ message Finding {
103102
// the firewall became open. The accuracy is determined by the detector.
104103
google.protobuf.Timestamp event_time = 9;
105104

106-
// The time at which the finding was created in Cloud SCC.
105+
// The time at which the finding was created in Security Command Center.
107106
google.protobuf.Timestamp create_time = 10;
108107
}

google/cloud/securitycenter/v1beta1/organization_settings.proto

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2019 Google LLC.
1+
// Copyright 2020 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
//
1514

1615
syntax = "proto3";
1716

@@ -24,8 +23,8 @@ option go_package = "google.golang.org/genproto/googleapis/cloud/securitycenter/
2423
option java_multiple_files = true;
2524
option java_package = "com.google.cloud.securitycenter.v1beta1";
2625

27-
// User specified settings that are attached to the Cloud Security Command
28-
// Center (Cloud SCC) organization.
26+
// User specified settings that are attached to the Security Command
27+
// Center organization.
2928
message OrganizationSettings {
3029
option (google.api.resource) = {
3130
type: "securitycenter.googleapis.com/OrganizationSettings"

google/cloud/securitycenter/v1beta1/run_asset_discovery_response.proto

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2019 Google LLC.
1+
// Copyright 2020 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
//
1514

1615
syntax = "proto3";
1716

google/cloud/securitycenter/v1beta1/security_marks.proto

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2019 Google LLC.
1+
// Copyright 2020 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
//
1514

1615
syntax = "proto3";
1716

@@ -24,9 +23,9 @@ option go_package = "google.golang.org/genproto/googleapis/cloud/securitycenter/
2423
option java_multiple_files = true;
2524
option java_package = "com.google.cloud.securitycenter.v1beta1";
2625

27-
// User specified security marks that are attached to the parent Cloud Security
28-
// Command Center (Cloud SCC) resource. Security marks are scoped within a Cloud
29-
// SCC organization -- they can be modified and viewed by all users who have
26+
// User specified security marks that are attached to the parent Security
27+
// Command Center resource. Security marks are scoped within a Security Command
28+
// Center organization -- they can be modified and viewed by all users who have
3029
// proper permissions on the organization.
3130
message SecurityMarks {
3231
option (google.api.resource) = {

google/cloud/securitycenter/v1beta1/securitycenter_service.proto

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2019 Google LLC.
1+
// Copyright 2020 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
//
1514

1615
syntax = "proto3";
1716

google/cloud/securitycenter/v1beta1/securitycenter_v1beta1.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
type: google.api.Service
22
config_version: 3
33
name: securitycenter.googleapis.com
4-
title: Cloud Security Command Center API
4+
title: Security Command Center API
55

66
apis:
77
- name: google.cloud.securitycenter.v1beta1.SecurityCenter
@@ -11,13 +11,13 @@ types:
1111

1212
documentation:
1313
summary: |-
14-
Cloud Security Command Center API provides access to temporal views of
15-
assets and findings within an organization.
14+
Security Command Center API provides access to temporal views of assets and
15+
findings within an organization.
1616
1717
backend:
1818
rules:
1919
- selector: 'google.cloud.securitycenter.v1beta1.SecurityCenter.*'
20-
deadline: 60.0
20+
deadline: 480.0
2121
- selector: 'google.longrunning.Operations.*'
2222
deadline: 60.0
2323

google/cloud/securitycenter/v1beta1/source.proto

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2019 Google LLC.
1+
// Copyright 2020 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -11,7 +11,6 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
//
1514

1615
syntax = "proto3";
1716

@@ -24,7 +23,7 @@ option go_package = "google.golang.org/genproto/googleapis/cloud/securitycenter/
2423
option java_multiple_files = true;
2524
option java_package = "com.google.cloud.securitycenter.v1beta1";
2625

27-
// Cloud Security Command Center's (Cloud SCC) finding source. A finding source
26+
// Security Command Center finding source. A finding source
2827
// is an entity or a mechanism that can produce a finding. A source is like a
2928
// container of findings that come from the same scanner, logger, monitor, etc.
3029
message Source {
@@ -48,7 +47,7 @@ message Source {
4847

4948
// The description of the source (max of 1024 characters).
5049
// Example:
51-
// "Cloud Security Scanner is a web security scanner for common
50+
// "Web Security Scanner is a web security scanner for common
5251
// vulnerabilities in App Engine applications. It can automatically
5352
// scan and detect four common vulnerabilities, including cross-site-scripting
5453
// (XSS), Flash injection, mixed content (HTTP in HTTPS), and

0 commit comments

Comments
 (0)