fix!: rename the type FunnelFilter to FunnelFieldFilter

Google APIs · copybara-github · commit 48494807478b · 2022-06-15T13:19:09.000-07:00
fix!: rename the `funnel_filter` field of the `FunnelFilterExpression` type to `funnel_field_filter`

PiperOrigin-RevId: 455204231
diff --git a/google/analytics/data/v1alpha/analytics_data_api.proto b/google/analytics/data/v1alpha/analytics_data_api.proto
@@ -96,9 +96,12 @@ message RunFunnelReportRequest {
 
   // If specified, next action adds a dimension to the funnel visualization sub
   // report response. This next action dimension expands each funnel step to the
-  // unique values of the next action. For example a breakdown by the
+  // unique values of the next action. For example a next action of the
   // `eventName` dimension will create rows for several events (i.e.
   // `session_start` & `click`) and the total.
+  //
+  // Next action only supports `eventName` and most Page / Screen dimensions
+  // like `pageTitle` and `pagePath`.
   FunnelNextAction funnel_next_action = 5;
 
   // The funnel visualization type controls the dimensions present in the funnel
diff --git a/google/analytics/data/v1alpha/data.proto b/google/analytics/data/v1alpha/data.proto
@@ -403,7 +403,10 @@ message FunnelNextAction {
   // The dimension column added to the funnel visualization sub report response.
   // The next action dimension returns the next dimension value of this
   // dimension after the user has attained the `i`th funnel step.
-  // `nextActionDimension` currently only supports the `eventName` dimension.
+  //
+  // `nextActionDimension` currently only supports `eventName` and most Page /
+  // Screen dimensions like `pageTitle` and `pagePath`. `nextActionDimension`
+  // cannot be a dimension expression.
   Dimension next_action_dimension = 1;
 
   // The maximum number of distinct values of the breakdown dimension to return
@@ -1026,8 +1029,8 @@ message FunnelFilterExpression {
     // The FunnelFilterExpression is NOT of `notExpression`.
     FunnelFilterExpression not_expression = 3;
 
-    // A primitive funnel filter.
-    FunnelFilter funnel_filter = 4;
+    // A funnel filter for a dimension or metric.
+    FunnelFieldFilter funnel_field_filter = 4;
 
     // Creates a filter that matches events of a single event name. If a
     // parameter filter expression is specified, only the subset of events that
@@ -1044,7 +1047,7 @@ message FunnelFilterExpressionList {
 }
 
 // An expression to filter dimension or metric values.
-message FunnelFilter {
+message FunnelFieldFilter {
   // The dimension name or metric name.
   string field_name = 1;
 
