Skip to content

Commit 24f0736

Browse files
Google APIscopybara-github
authored andcommitted
fix!: Removed resource definition of Compute API resources and incorrect resource references that used them
PiperOrigin-RevId: 459444490
1 parent ccb6738 commit 24f0736

3 files changed

Lines changed: 15 additions & 19 deletions

File tree

google/cloud/certificatemanager/v1/BUILD.bazel

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ proto_library_with_info(
3939
deps = [
4040
":certificatemanager_proto",
4141
"//google/cloud:common_resources_proto",
42+
"//google/cloud/location:location_proto",
4243
],
4344
)
4445

@@ -73,11 +74,13 @@ java_gapic_library(
7374
service_yaml = "certificatemanager_v1.yaml",
7475
test_deps = [
7576
":certificatemanager_java_grpc",
77+
"//google/cloud/location:location_java_grpc",
7678
],
7779
transport = "grpc+rest",
7880
deps = [
7981
":certificatemanager_java_proto",
8082
"//google/api:api_java_proto",
83+
"//google/cloud/location:location_java_proto",
8184
],
8285
)
8386

@@ -135,6 +138,7 @@ go_gapic_library(
135138
transport = "grpc+rest",
136139
deps = [
137140
":certificatemanager_go_proto",
141+
"//google/cloud/location:location_go_proto",
138142
"//google/longrunning:longrunning_go_proto",
139143
"@com_google_cloud_go//longrunning:go_default_library",
140144
"@com_google_cloud_go//longrunning/autogen:go_default_library",
@@ -177,6 +181,7 @@ py_gapic_library(
177181
"python-gapic-namespace=google.cloud",
178182
"warehouse-package-name=google-cloud-certificate-manager",
179183
],
184+
service_yaml = "certificatemanager_v1.yaml",
180185
)
181186

182187
# Open Source Packages
@@ -292,6 +297,7 @@ ruby_cloud_gapic_library(
292297
grpc_service_config = "certificatemanager_grpc_service_config.json",
293298
ruby_cloud_description = "Certificate Manager lets you acquire and manage Transport Layer Security (TLS) (SSL) certificates for use with classic external HTTP(S) load balancers in Google Cloud.",
294299
ruby_cloud_title = "Certificate Manager V1",
300+
service_yaml = "certificatemanager_v1.yaml",
295301
deps = [
296302
":certificatemanager_ruby_grpc",
297303
":certificatemanager_ruby_proto",

google/cloud/certificatemanager/v1/certificate_manager.proto

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,6 @@ option java_outer_classname = "CertificateManagerProto";
3131
option java_package = "com.google.cloud.certificatemanager.v1";
3232
option php_namespace = "Google\\Cloud\\CertificateManager\\V1";
3333
option ruby_package = "Google::Cloud::CertificateManager::V1";
34-
option (google.api.resource_definition) = {
35-
type: "compute.googleapis.com/TargetHttpsProxies"
36-
pattern: "projects/{project}/locations/{location}/targetHttpsProxies/{target_https_proxy}"
37-
};
38-
option (google.api.resource_definition) = {
39-
type: "compute.googleapis.com/TargetSslProxies"
40-
pattern: "projects/{project}/locations/{location}/targetSslProxies/{target_ssl_proxy}"
41-
};
4234

4335
// API Overview
4436
//
@@ -912,17 +904,13 @@ message CertificateMap {
912904

913905
// A Target Proxy to which this map is attached to.
914906
oneof target_proxy {
915-
// A name must be in the format
916-
// `projects/*/locations/*/targetHttpsProxies/*`.
917-
string target_https_proxy = 1 [(google.api.resource_reference) = {
918-
type: "compute.googleapis.com/TargetHttpsProxies"
919-
}];
920-
921-
// A name must be in the format
922-
// `projects/*/locations/*/targetSslProxies/*`.
923-
string target_ssl_proxy = 3 [(google.api.resource_reference) = {
924-
type: "compute.googleapis.com/TargetSslProxies"
925-
}];
907+
// This field returns the resource name in the following format:
908+
// `//compute.googleapis.com/projects/*/global/targetHttpsProxies/*`.
909+
string target_https_proxy = 1;
910+
911+
// This field returns the resource name in the following format:
912+
// `//compute.googleapis.com/projects/*/global/targetSslProxies/*`.
913+
string target_ssl_proxy = 3;
926914
}
927915

928916
// IP configurations for this Target Proxy where the

google/cloud/certificatemanager/v1/certificatemanager_v1.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ title: Certificate Manager API
55

66
apis:
77
- name: google.cloud.certificatemanager.v1.CertificateManager
8+
- name: google.cloud.location.Locations
9+
- name: google.longrunning.Operations
810

911
types:
1012
- name: google.cloud.certificatemanager.v1.OperationMetadata

0 commit comments

Comments
 (0)