samples(pubsub): pubsub_subscriber_error_listener v2 upgrade and testing

cy-yun · cy-yun · commit f0af41f86a84 · 2025-08-05T14:14:35.000-07:00
diff --git a/google-cloud-pubsub/samples/acceptance/subscriptions_test.rb b/google-cloud-pubsub/samples/acceptance/subscriptions_test.rb
@@ -22,6 +22,7 @@
 require_relative "../pubsub_subscriber_flow_settings.rb"
 require_relative "../pubsub_subscriber_async_pull.rb"
 require_relative "../pubsub_subscriber_concurrency_control.rb"
+require_relative "../pubsub_subscriber_error_listener.rb"
 require_relative "../pubsub_subscriber_sync_pull_with_lease.rb"
 require_relative "../pubsub_update_push_configuration.rb"
 require_relative "../pubsub_list_subscriptions.rb"
@@ -164,6 +165,19 @@
     end
   end
 
+  it "supports pubsub_subscriber_error_listener" do
+    publisher = pubsub.publisher @topic.name
+    publisher.publish "This is a test message."
+    sleep 5
+
+    # pubsub_subscriber_error_listener
+    expect_with_retry "pubsub_subscriber_error_listener" do
+      assert_output "Received message: This is a test message.\n" do
+        listen_for_messages_with_error_handler subscription_id: @subscription.name
+      end
+    end
+  end
+
   it "supports pubsub_subscriber_async_pull_custom_attributes" do
     publisher = pubsub.publisher @topic.name
     publisher.publish "This is a test message.", origin: "ruby-sample"
diff --git a/google-cloud-pubsub/samples/pubsub_subscriber_error_listener.rb b/google-cloud-pubsub/samples/pubsub_subscriber_error_listener.rb
@@ -20,8 +20,8 @@ def listen_for_messages_with_error_handler subscription_id:
 
   pubsub = Google::Cloud::PubSub.new
 
-  subscription = pubsub.subscription subscription_id
-  subscriber   = subscription.listen do |received_message|
+  subscriber = pubsub.subscriber subscription_id
+  listener   = subscriber.listen do |received_message|
     puts "Received message: #{received_message.data}"
     received_message.acknowledge!
   end
@@ -31,11 +31,11 @@ def listen_for_messages_with_error_handler subscription_id:
   Thread.abort_on_exception = true
 
   begin
-    subscriber.start
+    listener.start
     # Let the main thread sleep for 60 seconds so the thread for listening
     # messages does not quit
     sleep 60
-    subscriber.stop.wait!
+    listener.stop.wait!
   rescue StandardError => e
     puts "Exception #{e.inspect}: #{e.message}"
     raise "Stopped listening for messages."
