docs(pubsub): Fix style on GCS ingestion sample

michaelpri10 · michaelpri10 · commit a1e6e4cea10a · 2024-10-11T16:15:40.000-04:00
diff --git a/google-cloud-pubsub/samples/pubsub_create_topic_with_cloud_storage_ingestion.rb b/google-cloud-pubsub/samples/pubsub_create_topic_with_cloud_storage_ingestion.rb
@@ -14,7 +14,14 @@
 
 require "google/cloud/pubsub"
 
-def create_topic_with_cloud_storage_ingestion topic_id:, bucket:, input_format:, text_delimiter:, match_glob:, minimum_object_create_time:
+# rubocop:disable Metrics/MethodLength
+
+def create_topic_with_cloud_storage_ingestion topic_id:,
+                                              bucket:,
+                                              input_format:,
+                                              text_delimiter:,
+                                              match_glob:,
+                                              minimum_object_create_time:
   # [START pubsub_create_topic_with_cloud_storage_ingestion]
   # project_id = "your-project-id"
   # topic_id = "your-topic-id"
@@ -25,16 +32,15 @@ def create_topic_with_cloud_storage_ingestion topic_id:, bucket:, input_format:,
   # minimum_object_create_time = "YYYY-MM-DDThh:mm:ssZ"
 
   pubsub = Google::Cloud::Pubsub.new
-
   cloud_storage_settings = Google::Cloud::PubSub::V1::IngestionDataSourceSettings::CloudStorage.new(
     bucket: bucket,
+    match_glob: match_glob
   )
-
   case input_format
   when "text"
     cloud_storage_settings.text_format =
       Google::Cloud::PubSub::V1::IngestionDataSourceSettings::CloudStorage::TextFormat.new(
-        delimiter: text_delimiter,
+        delimiter: text_delimiter
       )
   when "avro"
     cloud_storage_settings.avro_format =
@@ -46,21 +52,15 @@ def create_topic_with_cloud_storage_ingestion topic_id:, bucket:, input_format:,
     puts "Invalid input format: #{input_format}; must be in ('text', 'avro', 'pubsub_avro')"
     return
   end
-
-  unless match_glob.empty?
-    cloud_storage_settings.match_glob = match_glob
-  end
-
   unless minimum_object_create_time.empty?
-    minimum_object_create_time_timestamp = Time.parse(minimum_object_create_time)
-    cloud_storage_settings.minimum_object_create_time = minimum_object_create_time_timestamp
+    cloud_storage_settings.minimum_object_create_time = Time.parse minimum_object_create_time
   end
-
   ingestion_data_source_settings = Google::Cloud::PubSub::V1::IngestionDataSourceSettings.new(
-    cloud_storage: cloud_storage_settings,
+    cloud_storage: cloud_storage_settings
   )
   topic = pubsub.create_topic topic_id, ingestion_data_source_settings: ingestion_data_source_settings
-
   puts "Topic #{topic.name} with Cloud Storage ingestion settings created."
   # [END pubsub_create_topic_with_cloud_storage_ingestion]
 end
+
+# rubocop:enable Metrics/MethodLength
