From 3f20f577e72452720597ba2edd7374de4043e034 Mon Sep 17 00:00:00 2001 From: Tres Seaver Date: Thu, 26 Jul 2018 13:18:23 -0400 Subject: [PATCH] Add 'Message.ack_id' property. Also, add explicit test for 'Message.size' property. Closes #5691. --- pubsub/google/cloud/pubsub_v1/subscriber/message.py | 5 +++++ .../tests/unit/pubsub_v1/subscriber/test_message.py | 11 +++++++++++ 2 files changed, 16 insertions(+) diff --git a/pubsub/google/cloud/pubsub_v1/subscriber/message.py b/pubsub/google/cloud/pubsub_v1/subscriber/message.py index 091826007ae3..6772f196bf60 100644 --- a/pubsub/google/cloud/pubsub_v1/subscriber/message.py +++ b/pubsub/google/cloud/pubsub_v1/subscriber/message.py @@ -164,6 +164,11 @@ def size(self): """Return the size of the underlying message, in bytes.""" return self._message.ByteSize() + @property + def ack_id(self): + """str: the ID used to ack the message.""" + return self._ack_id + def ack(self): """Acknowledge the given message. diff --git a/pubsub/tests/unit/pubsub_v1/subscriber/test_message.py b/pubsub/tests/unit/pubsub_v1/subscriber/test_message.py index 4089d4d5109d..bb87dec3518c 100644 --- a/pubsub/tests/unit/pubsub_v1/subscriber/test_message.py +++ b/pubsub/tests/unit/pubsub_v1/subscriber/test_message.py @@ -61,6 +61,17 @@ def test_data(): assert msg.data == b'foo' +def test_size(): + msg = create_message(b'foo') + assert msg.size == 30 # payload + protobuf overhead + + +def test_ack_id(): + ack_id = 'MY-ACK-ID' + msg = create_message(b'foo', ack_id=ack_id) + assert msg.ack_id == ack_id + + def test_publish_time(): msg = create_message(b'foo') assert msg.publish_time == PUBLISHED