fix(storage): ensure bidi-gRPC stream is cleaned up on open failure and close - #18119
Draft
zhixiangli wants to merge 2 commits into
Draft
fix(storage): ensure bidi-gRPC stream is cleaned up on open failure and close#18119zhixiangli wants to merge 2 commits into
zhixiangli wants to merge 2 commits into
Conversation
…nd close - Ensure socket_like_rpc is closed if open() or the initial recv() fails or is cancelled in _AsyncReadObjectStream.open() - Add _close_socket_like_rpc helper to safely handle RPC closure - Only call requests_done() in close() if socket_like_rpc is active, and ensure stream state and RPC are closed even if requests_done() fails - Add unit tests for open failures/cancellations and close behavior on inactive or failing streams
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces robust exception handling and resource cleanup in _AsyncReadObjectStream during stream initialization and closure. Specifically, it wraps the bidi-gRPC stream opening and receiving logic in a try-except block to ensure the stream is closed if an error or cancellation occurs, and updates the close method to safely close the RPC connection even if signaling requests are done fails. Corresponding unit tests have been added to verify these error handling and cleanup paths. Feedback on the changes suggests consolidating the duplicate exception handling blocks for asyncio.CancelledError and Exception in the open method into a single block to reduce redundancy.
…nc_read_object_stream.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕