fix: fix the boolean coercion bug for any() and all() in SQLGlot - #18090
Draft
sycai wants to merge 2 commits into
Draft
fix: fix the boolean coercion bug for any() and all() in SQLGlot#18090sycai wants to merge 2 commits into
sycai wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the boolean coercion logic by introducing a reusable helper function _to_nullable_bool in common.py. This helper is now utilized in both unary_compiler.py (for LOGICAL_AND and LOGICAL_OR aggregations) and generic_ops.py (for coerce_to_bool_op), replacing duplicate type-checking logic. Additionally, unit tests and SQL snapshots have been updated to cover string and array-like types. There are no review comments, so we have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably won't merge the PR as we will start using GoB as the source of truth soon. Uploading the code changes purely for references.