fix(crc32c): escape the version dot and anchor the pyenv check regex#17555
Draft
chalmerlowe wants to merge 4 commits into
Draft
fix(crc32c): escape the version dot and anchor the pyenv check regex#17555chalmerlowe wants to merge 4 commits into
chalmerlowe wants to merge 4 commits into
Conversation
…nt matching sub-versions like 3.13.14
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves Python version matching in macOS build and publish scripts by escaping dots and using anchors/word boundaries in grep patterns. The feedback suggests refactoring the bash conditional checks from [ -z "$(pipeline | grep ...)" ] to a more idiomatic and efficient if ! pipeline | grep -q ...; then pattern to avoid unnecessary subshells and string comparisons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OS X python wheel build script (
build_python_wheel.sh) checks if a Python version is installed inpyenvbefore building:When $version is 3.14, this expands to grep 3.14. Because the dot (.) is not escaped, it is treated as a wildcard and will also match the substring 3.13.14 (which contains 3.14 at the end). This results in a false positive, causing the script to skip compiling Python 3.14. The script then fails when executing pyenv shell 3.14 with a "version not installed" error.
Solution
Escape the version dots in bash:
${version//./\.}.Anchor the grep match with line start (
^) and word boundaries (\b) to ensure it only matches the exact version line (e.g.^3\.14\binstead of matching3.13.14).Applied this fix to both
build_python_wheel.shandpublish_python_wheel.sh.