diff --git a/packages/google-cloud-bigtable/google/cloud/bigtable/data/execute_query/_parameters_formatting.py b/packages/google-cloud-bigtable/google/cloud/bigtable/data/execute_query/_parameters_formatting.py index 816e9fbe1180..878d4650a71b 100644 --- a/packages/google-cloud-bigtable/google/cloud/bigtable/data/execute_query/_parameters_formatting.py +++ b/packages/google-cloud-bigtable/google/cloud/bigtable/data/execute_query/_parameters_formatting.py @@ -39,7 +39,7 @@ def _format_execute_query_view_params( raise TypeError( f"View parameter {key} must be a string, got {type(value).__name__}" ) - result_values[key] = Value(string_value=value) + result_values[key] = _convert_value_to_pb_value_dict(value, SqlType.String()) return result_values diff --git a/packages/google-cloud-bigtable/tests/unit/data/_async/test_client.py b/packages/google-cloud-bigtable/tests/unit/data/_async/test_client.py index 8d2aa9872d01..626eb1bf9085 100644 --- a/packages/google-cloud-bigtable/tests/unit/data/_async/test_client.py +++ b/packages/google-cloud-bigtable/tests/unit/data/_async/test_client.py @@ -3558,6 +3558,8 @@ async def test_execute_query_with_view_parameters( request = execute_query_mock.call_args[0][0] assert "user_id" in request.view_parameters assert request.view_parameters["user_id"].string_value == "alice" + val_type = request.view_parameters["user_id"].type_ + assert type(val_type).to_dict(val_type) == {"string_type": {}} @CrossSync.pytest async def test_execute_query_with_view_parameters_invalid_type( diff --git a/packages/google-cloud-bigtable/tests/unit/data/_sync_autogen/test_client.py b/packages/google-cloud-bigtable/tests/unit/data/_sync_autogen/test_client.py index ca5158381774..f21900e7aaa3 100644 --- a/packages/google-cloud-bigtable/tests/unit/data/_sync_autogen/test_client.py +++ b/packages/google-cloud-bigtable/tests/unit/data/_sync_autogen/test_client.py @@ -3019,6 +3019,8 @@ def test_execute_query_with_view_parameters( request = execute_query_mock.call_args[0][0] assert "user_id" in request.view_parameters assert request.view_parameters["user_id"].string_value == "alice" + val_type = request.view_parameters["user_id"].type_ + assert type(val_type).to_dict(val_type) == {"string_type": {}} def test_execute_query_with_view_parameters_invalid_type( self, client, execute_query_mock, prepare_mock