feat(auth): Ensure new auth SDK versions are backwards compatible with previous SDKs to enable copying to G3#17407
Open
macastelaz wants to merge 6 commits into
Open
feat(auth): Ensure new auth SDK versions are backwards compatible with previous SDKs to enable copying to G3#17407macastelaz wants to merge 6 commits into
macastelaz wants to merge 6 commits into
Conversation
…nd circular import decoupling - Restore fail-fast validation in _mtls_helper.py - Add robustness guardrails to impersonated_credentials.py for universe_domain - Safeguard RSA Signer & key_id in rsa.py - Break circular import in credentials.py - Update unit tests in test__mtls_helper.py to match new behavior and run robustly in Google environments. TAG=agy CONV=39c1761f-e06b-4e3a-80b6-b4fbc70df0b6
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic imports for regional access boundary lookups, adds robust environment variable validation for client certificates, and improves fallback handling for universe domains and key IDs. The review feedback highlights opportunities to make the code more robust and efficient, such as performing safe None checks before accessing object properties in rsa.py, avoiding falsy value issues when retrieving key_id, and eliminating redundant attribute lookups in impersonated_credentials.py.
…s module attribute TAG=agy CONV=39c1761f-e06b-4e3a-80b6-b4fbc70df0b6
…ey_id TAG=agy CONV=39c1761f-e06b-4e3a-80b6-b4fbc70df0b6
…impersonated credentials TAG=agy CONV=39c1761f-e06b-4e3a-80b6-b4fbc70df0b6
TAG=agy CONV=39c1761f-e06b-4e3a-80b6-b4fbc70df0b6
TAG=agy CONV=39c1761f-e06b-4e3a-80b6-b4fbc70df0b6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporate universal bug fixes, robustness guardrails, and circular import decoupling
TAG=agy
CONV=39c1761f-e06b-4e3a-80b6-b4fbc70df0b6