chore(.generator): release staging preview support#17159
Open
noahdietz wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for preview packages by directing them to a preview-packages/ directory in mono-repos. It adds helper functions _get_package_name and _get_library_path to manage these paths and updates the changelog, metadata, and release logic accordingly. Feedback suggests using re.escape() when embedding the package name into a regular expression to ensure special characters are handled correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
legacylibrarianPython processor to support staging releases for Preview packages.Preview packages are generated into
./preview-packagesdirectory with an package name and directory mirroring the stable variant under./packages(doc). TheirlegacylibrarianID, however, is-previewsuffixed (so that there can be a unique entry in the config), and used as a signal to the tooling that the library in question is a preview library and is in a different location. The contents of the library package is otherwise identical.Towards googleapis/librarian#5894