Skip to content

chore(nox): chore update noxfile with format session that uses ruff#16647

Draft
chalmerlowe wants to merge 4 commits intomainfrom
chore-update-to-ruff
Draft

chore(nox): chore update noxfile with format session that uses ruff#16647
chalmerlowe wants to merge 4 commits intomainfrom
chore-update-to-ruff

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe commented Apr 14, 2026

Partial fix for #16014

Provides the following update to multiple noxfiles:

  • Adds a version number for ruff
  • Adds OR edits a format nox session to use ruff for formatting
  • Formats the edited noxfiles.

What it does NOT do:

This is not a universal panacea... it is purposefully kept lean and focuses on a single task.
It does not delete black versions, it does not delete isort versions, etc.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces isort and black with ruff for code formatting and import sorting across multiple packages. The review identifies several issues, including missing tool installations, missing session implementations, and the use of undefined variables. It also recommends removing redundant formatting sessions, restoring type hints, and refactoring duplicated path lists to improve maintainability.

chalmerlowe and others added 2 commits April 14, 2026 09:08
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@chalmerlowe
Copy link
Copy Markdown
Contributor Author

Unit test failures are in sqlalchemy-spanner.
No changes introduced in this PR should cause the unit tests to fail. I believe this is an unrelated issue that is out of scope for this update.

@chalmerlowe
Copy link
Copy Markdown
Contributor Author

@gemini-code-assist
Are you able to identify the reasons for the failing tests?
I don't need you to generate commits or patches yet. Please just summarize the reasons for the failing tests, if you are able so that we can consider them and determine whether they should be included as "in scope" in this PR or handled in another PR.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

@chalmerlowe Thank you for reaching out. Based on the changes introduced in this pull request, which primarily involve updating noxfile.py configurations to use ruff for code formatting and import sorting, there is no direct logical connection to unit test failures in the sqlalchemy-spanner library.

The modifications are confined to the build and formatting tooling, not the functional code of the sqlalchemy-spanner package itself. Therefore, it is highly probable that the unit test failures you are observing are indeed an unrelated issue, as you've already suspected.

Without access to the specific unit test logs or error messages, it's impossible for me to pinpoint the exact cause of the failures. However, if the ruff installation or its execution within the nox environment were to indirectly cause dependency conflicts or environmental issues that affect the test runner, that would be an extremely rare and indirect cause. The most straightforward conclusion, given the nature of these changes, is that the test failures are independent of this PR.

I recommend investigating the sqlalchemy-spanner unit test logs for specific error messages to understand the root cause, as it's likely an issue external to the formatting tool update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant