From 90d3efeda7c48227ec0f4515399c2da8673aa0d8 Mon Sep 17 00:00:00 2001 From: Anthonios Partheniou Date: Wed, 14 Feb 2024 17:37:34 -0500 Subject: [PATCH 1/2] ci: resolve issue where docs failures do not appear in presubmits --- ci/run_single_test.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/run_single_test.sh b/ci/run_single_test.sh index 662a5f1c743d..7d25aeb5b187 100755 --- a/ci/run_single_test.sh +++ b/ci/run_single_test.sh @@ -50,21 +50,21 @@ case ${TEST_TYPE} in ;; docs) nox -s docs + retval=$? # Clean up built docs and python cache after the build process to avoid # `[Errno 28] No space left on device` # See https://github.com/googleapis/google-cloud-python/issues/12271 rm -rf docs/_build find . | grep -E "(__pycache__)" | xargs rm -rf - retval=$? ;; docfx) nox -s docfx + retval=$? # Clean up built docs and python cache after the build process to avoid # `[Errno 28] No space left on device` # See https://github.com/googleapis/google-cloud-python/issues/12271 rm -rf docs/_build find . | grep -E "(__pycache__)" | xargs rm -rf - retval=$? ;; prerelease) nox -s prerelease_deps-3.12 From d32931badc37d269fe3c42d45de4e86404ab5db7 Mon Sep 17 00:00:00 2001 From: Anthonios Partheniou Date: Wed, 14 Feb 2024 17:44:30 -0500 Subject: [PATCH 2/2] add comment --- ci/run_single_test.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ci/run_single_test.sh b/ci/run_single_test.sh index 7d25aeb5b187..68e88ed98e46 100755 --- a/ci/run_single_test.sh +++ b/ci/run_single_test.sh @@ -50,6 +50,8 @@ case ${TEST_TYPE} in ;; docs) nox -s docs + # This line needs to be directly after `nox -s docs` in order + # for the failure to appear in Github presubmits retval=$? # Clean up built docs and python cache after the build process to avoid # `[Errno 28] No space left on device` @@ -59,6 +61,8 @@ case ${TEST_TYPE} in ;; docfx) nox -s docfx + # This line needs to be directly after `nox -s docfx` in order + # for the failure to appear in Github presubmits retval=$? # Clean up built docs and python cache after the build process to avoid # `[Errno 28] No space left on device`