Skip to content

BigQuery: Add Connection object to Magics Context #8024

Closed

Description

@vimota

Is your feature request related to a problem? Please describe.
Our team (Kaggle) supports a Public Datasets BigQuery integration in Kernels (Jupyter Notebooks) using a proxy where we inject our own credentials. We currently expose a PublicBigQueryClient that handles this (https://github.com/Kaggle/docker-python/blob/master/patches/kaggle_gcp.py#L70) but we're unable to support Magics via this mechanism since we need to be able to pass in a Connection object to the client.
Describe the solution you'd like
Being able to set either the client object or the Connection object of the Magic (like Context.set_credentials) would solve this.
Describe alternatives you've considered
We've considered monkeypatching the magics client but that may cause more problems.

Activity

  1. tswast commented on May 17, 2019

    @tswast
    Contributor

    I'd be open to a PR that adds a _connection property to Context.

  2. added
    api: bigqueryIssues related to the BigQuery API.
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    on May 17, 2019
  3. tswast commented on May 17, 2019

    @tswast
    Contributor

    The reason I don't think client would be a good property for Context is that there are many default values on Client that are also present in Context. I gets too confusing to know which to set.

  4. tswast commented on May 31, 2019

    @tswast
    Contributor

    Fixed by #8192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: bigqueryIssues related to the BigQuery API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions