You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
BigQuery: Add Connection object to Magics Context #8024
Is your feature request related to a problem? Please describe.
Our team (Kaggle) supports a Public Datasets BigQuery integration in Kernels (Jupyter Notebooks) using a proxy where we inject our own credentials. We currently expose a PublicBigQueryClient that handles this (https://github.com/Kaggle/docker-python/blob/master/patches/kaggle_gcp.py#L70) but we're unable to support Magics via this mechanism since we need to be able to pass in a Connection object to the client. Describe the solution you'd like
Being able to set either the client object or the Connection object of the Magic (like Context.set_credentials) would solve this. Describe alternatives you've considered
We've considered monkeypatching the magics client but that may cause more problems.
The reason I don't think client would be a good property for Context is that there are many default values on Client that are also present in Context. I gets too confusing to know which to set.
Activity
tswast commentedon May 17, 2019
I'd be open to a PR that adds a
_connectionproperty toContext.tswast commentedon May 17, 2019
The reason I don't think
clientwould be a good property forContextis that there are many default values onClientthat are also present inContext. I gets too confusing to know which to set.tswast commentedon May 31, 2019
Fixed by #8192.