Core: Retry.__init__ add on_error arg #7951

Activity

1. yoshi-automation

   added

   triage meI really want to be triaged.I really want to be triaged.

   on May 13, 2019
2. sduskis

   added

   api: core

   type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.

   and removed

   triage meI really want to be triaged.I really want to be triaged.

   on May 13, 2019
3. emar-kar commented on Jul 25, 2019

   

   emar-kar

   on Jul 25, 2019

   Contributor

   More actions

   @xmedeko Could you explain some details, please. As I understand you would like to add on_error argument into the Retry.__init__ method, but I really can not get how are you going to use it? Do you want it to be the class attribute, or you want it to be called in __init__?
4. tseaver commented on Jul 25, 2019

   

   tseaver

   on Jul 25, 2019

   Contributor

   More actions

   @emar-kar I read the request that the on_error passed to the constructor would be saved as an attribute on the Retry instance, and used in every invocation as a fall-back if no on_error is passed. E.g.:

   from google.api_core.retry import Retry
   
   def error_callback(exception):
       psas
   
   retry = Retry(on_error=error_callback)
   
   # callback invoked for retryable exceptions
   retry(some_object.delete)()

   👍React with 👍2Reacted by Ondrej Medek and Leo Emar-Kar
5. busunkim96

   closed this as completedin #8892on Aug 22, 2019
6. IlyaFaer

   changed the title [-]Core: Retry.__init__ add on_error[/-] [+]Core: Retry.__init__ add on_error arg[/+] on Jan 23, 2020
7. JustinBeckwith

   assigned

   busunkim96

   on Feb 1, 2021