Skip to content

BigQuery: Let bqstorage_client authentication errors be raised in to_dataframe #7661

Closed
Closed
BigQuery: Let bqstorage_client authentication errors be raised in to_dataframe#7661
Assignees
tswast
Labels
api: bigqueryIssues related to the BigQuery API.api: bigquerystorageIssues related to the BigQuery Storage API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@tswast
tswast
opened on Apr 4, 2019

Now that I'm trying to write a tutorial on using the BigQuery Storage API to download query results, I've had a change of heart regarding whether to_dataframe should fall back to the tabledata.list API when there are authentication errors. Originally, I thought we should fallback on authentication errors, but now I see that it hides problems.

Someone could have downloaded the right libraries but either don't have the right permissions or haven't enabled the API, but those errors will be swallowed. Instead, downloading large tables will be much slower than expected.

Activity

  1. tswast
    added
    api: bigqueryIssues related to the BigQuery API.
    api: bigquerystorageIssues related to the BigQuery Storage API.
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    and removed
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    on Apr 4, 2019

  2. tswast commented on Apr 5, 2019

    @tswast
    tswast
    on Apr 5, 2019
    ContributorAuthor

    I think this is worthy of being a bug. I consider it a "known issue" for to_dataframe that authorization errors can be swallowed.

  3. yoshi-automation
    added
    triage meI really want to be triaged.
    on Apr 5, 2019
  4. tswast
    self-assigned this
    on Apr 5, 2019
  5. tswast
    added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    and removed
    triage meI really want to be triaged.
    on Apr 5, 2019
  6. tswast
    closed this as completedin #7674on Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: bigqueryIssues related to the BigQuery API.api: bigquerystorageIssues related to the BigQuery Storage API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions