BigQuery: add destinationTableProperties to LoadJobConfig #5093

Activity

1. chemelnucfin

   added

   type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.

   api: bigqueryIssues related to the BigQuery API.Issues related to the BigQuery API.

   on Mar 22, 2018
2. tseaver

   self-assigned this

   on Oct 12, 2018
3. tseaver commented on Oct 12, 2018

   

   tseaver

   on Oct 12, 2018

   Contributor

   More actions

   @tswast while working on this, I am adding unit tests for each of the LoadJobConfig properties. I notice that skipLeadingRows is mangled to a string in the resource, while maxBadRows is not. Which is correct? Given that we are using JSON, and the numbers expected wouldn't be huge, I would think that leaving them both as integers would be correct. The docs show them both as integers.
4. tseaver

   added 2 commits that reference this issue on Oct 12, 2018

   Add explicit test coverage for 'LoadJobConfig.skip_leading_rows'.

   ...

   0805aa6

   Add 'LoadTableConfig.destination_table_friendly_name' property.

   ...

   1850daa
5. tswast commented on Oct 15, 2018

   

   tswast

   on Oct 15, 2018

   Contributor

   More actions

   Per the discovery document (https://www.googleapis.com/discovery/v1/apis/bigquery/v2/rest)

   maxBadRows is an int32 and can safely be represented as an integer in Google's JSON parser.

   skipLeadingRows is an int64, so needs to be encoded as a string for Google's JSON parser.

   I asked the BigQuery team this same question (why the inconsistency in types) and they didn't have a satisfactory answer.
6. tseaver

   added 2 commits that reference this issue on Oct 17, 2018

   Add explicit test coverage for 'LoadJobConfig.skip_leading_rows'.

   ...

   51aade2

   Add 'LoadTableConfig.destination_table_friendly_name' property.

   ...

   1240481
7. tseaver

   closed this as completedin #6202on Oct 17, 2018
8. tseaver

   added a commit that references this issue on Oct 17, 2018

   BigQuery: add destination table properties to 'LoadJobConfig'. (#6202)

   ...

   This issue will close once commit cf806f2 is merged into the 'main' branch.

   cf806f2