Skip to content

ensure we use retry classes correctly for {unary,streaming}×{sync,async} methods #16340

Closed as not planned

Description

@vchudnov-g

As per googleapis/python-api-core#528, GAPIC libraries currently have a race condition with unary async retries, which should be fixed by googleapis/python-api-core#495. And the GAPICs also do not handle the new streaming retry classes introduced in googleapis/python-api-core#495.

Once a version python-api-core with that merged PR gets released, we need to make sure that we use retries appropriately for streaming methods, in all transports. Also see this comment in that PR.

Activity

  1. added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Dec 11, 2023
  2. daniel-sanche commented on Feb 27, 2026

    @daniel-sanche
    Contributor

    This has been fixed for sync/async

    Streaming/unary is more complex, because you need product knowledge to really implement streaming retries properly

  3. parthea commented on Mar 26, 2026

    @parthea
    Contributor

    Transferring to google-cloud-python as the code for gapic-generator will be migrated there.

  4. daniel-sanche commented on May 27, 2026

    @daniel-sanche
    Contributor

    This issue is being closed as part of a bulk review (Filter #1). Please reopen if you believe this is still relevant and requires action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions