Current offenders:

system_tests/bigquery.py:124:        self.assertTrue(table._dataset is dataset)
system_tests/bigquery.py:150:                   table._dataset.name == DATASET_NAME]
system_tests/storage.py:120:        self.assertEqual(blob._properties, {})
system_tests/storage.py:134:        self.assertEqual(blob._properties, {})

Raw output before being combed through by Danny

$ git log --pretty=%H -1  # Current HEAD when checking
2c5df509433e76413f926755ac535642ed6467ea
$ git grep -n '\._' -- system_tests/
system_tests/bigquery.py:124:        self.assertTrue(table._dataset is dataset)
system_tests/bigquery.py:150:                   table._dataset.name == DATASET_NAME]
Binary file system_tests/data/five-point-one-mb-file.zip matches
system_tests/datastore.py:18:from gcloud._helpers import UTC
system_tests/datastore.py:87:        entity = self._get_post(id_or_name=(name or key_id))
system_tests/datastore.py:102:        self._generic_test_post(name='post1')
system_tests/datastore.py:105:        self._generic_test_post(key_id=123456789)
system_tests/datastore.py:108:        self._generic_test_post()
system_tests/datastore.py:112:            entity1 = self._get_post()
system_tests/datastore.py:126:            entity2 = self._get_post(post_content=second_post_content)
system_tests/datastore.py:176:        query = self._base_query()
system_tests/datastore.py:192:        query = self._base_query()
system_tests/datastore.py:200:        query = self._base_query()
system_tests/datastore.py:209:        filtered_query = self._base_query()
system_tests/datastore.py:219:        query = self._base_query()
system_tests/datastore.py:227:        query = self._base_query()
system_tests/datastore.py:239:        filtered_query = self._base_query()
system_tests/datastore.py:272:        page_query = self._base_query()
system_tests/datastore.py:295:        page_query = self._base_query()
system_tests/datastore.py:306:        fresh_query = self._base_query()
system_tests/datastore.py:317:        query = self._base_query()
system_tests/storage.py:26:from gcloud.storage._helpers import _base64_md5hash
system_tests/storage.py:120:        self.assertEqual(blob._properties, {})
system_tests/storage.py:134:        self.assertEqual(blob._properties, {})

System tests: remove use of protected attributes #1059

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions