Merge pull request #3424 from tseaver/3346-core-iam_policy_defaultdict_set

tseaver · web-flow · commit f12d84922e25 · 2017-05-16T16:58:30.000-04:00
iam.Policy: return empty set on missing key.
diff --git a/packages/google-cloud-core/google/cloud/iam.py b/packages/google-cloud-core/google/cloud/iam.py
@@ -59,7 +59,7 @@ class Policy(collections.MutableMapping):
     def __init__(self, etag=None, version=None):
         self.etag = etag
         self.version = version
-        self._bindings = {}
+        self._bindings = collections.defaultdict(set)
 
     def __iter__(self):
         return iter(self._bindings)
diff --git a/packages/google-cloud-core/tests/unit/test_iam.py b/packages/google-cloud-core/tests/unit/test_iam.py
@@ -52,8 +52,7 @@ def test_ctor_explicit(self):
 
     def test___getitem___miss(self):
         policy = self._make_one()
-        with self.assertRaises(KeyError):
-            policy['nonesuch']
+        self.assertEqual(policy['nonesuch'], set())
 
     def test___setitem__(self):
         USER = 'user:phred@example.com'
