test(samples): add backoff to cluster creation sample (#362)

tseaver · web-flow · commit cc2eb384ba64 · 2021-07-13T15:57:01.000-04:00
Closes #353.
diff --git a/packages/google-cloud-bigtable/samples/instanceadmin/requirements.txt b/packages/google-cloud-bigtable/samples/instanceadmin/requirements.txt
@@ -1 +1,2 @@
 google-cloud-bigtable==2.0.0
+backoff==1.11.0
diff --git a/packages/google-cloud-bigtable/samples/instanceadmin/test_instanceadmin.py b/packages/google-cloud-bigtable/samples/instanceadmin/test_instanceadmin.py
@@ -17,8 +17,9 @@
 import time
 import warnings
 
+import backoff
+from google.api_core import exceptions
 from google.cloud import bigtable
-
 import pytest
 
 import instanceadmin
@@ -128,7 +129,10 @@ def test_add_and_delete_cluster(capsys, dispose_of):
     capsys.readouterr()  # throw away output
 
     # Add a cluster to that instance
-    instanceadmin.add_cluster(PROJECT, INSTANCE, CLUSTER2)
+    # Avoid failing for "instance is currently being changed" by
+    # applying an exponential backoff
+    w_backoff = backoff.on_exception(backoff.expo, exceptions.ServiceUnavailable)
+    w_backoff(instanceadmin.add_cluster)(PROJECT, INSTANCE, CLUSTER2)
     out = capsys.readouterr().out
     assert f"Adding cluster to instance {INSTANCE}" in out
     assert "Listing clusters..." in out
