fix: add timeouts to unit tests

tswast · tswast · commit c10002e49475 · 2019-12-11T14:57:17.000-08:00
diff --git a/bigquery/tests/unit/test__http.py b/bigquery/tests/unit/test__http.py
@@ -75,7 +75,11 @@ def test_user_agent(self):
         }
         expected_uri = conn.build_api_url("/rainbow")
         http.request.assert_called_once_with(
-            data=req_data, headers=expected_headers, method="GET", url=expected_uri
+            data=req_data,
+            headers=expected_headers,
+            method="GET",
+            url=expected_uri,
+            timeout=None,
         )
         self.assertIn("my-application/1.2.3", conn.user_agent)
 
@@ -104,5 +108,9 @@ def test_extra_headers_replace(self):
         }
         expected_uri = conn.build_api_url("/rainbow")
         http.request.assert_called_once_with(
-            data=req_data, headers=expected_headers, method="GET", url=expected_uri
+            data=req_data,
+            headers=expected_headers,
+            method="GET",
+            url=expected_uri,
+            timeout=None,
         )
diff --git a/bigquery/tests/unit/test_client.py b/bigquery/tests/unit/test_client.py
@@ -1552,6 +1552,7 @@ def test_get_table_sets_user_agent(self):
                 "User-Agent": expected_user_agent,
             },
             data=mock.ANY,
+            timeout=None,
         )
         self.assertIn("my-application/1.2.3", expected_user_agent)
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,11 @@ def test_user_agent(self):`
`75`	`75`	`}`
`76`	`76`	`expected_uri = conn.build_api_url("/rainbow")`
`77`	`77`	`http.request.assert_called_once_with(`
`78`		`- data=req_data, headers=expected_headers, method="GET", url=expected_uri`
	`78`	`+ data=req_data,`
	`79`	`+ headers=expected_headers,`
	`80`	`+ method="GET",`
	`81`	`+ url=expected_uri,`
	`82`	`+ timeout=None,`
`79`	`83`	`)`
`80`	`84`	`self.assertIn("my-application/1.2.3", conn.user_agent)`
`81`	`85`
`@@ -104,5 +108,9 @@ def test_extra_headers_replace(self):`
`104`	`108`	`}`
`105`	`109`	`expected_uri = conn.build_api_url("/rainbow")`
`106`	`110`	`http.request.assert_called_once_with(`
`107`		`- data=req_data, headers=expected_headers, method="GET", url=expected_uri`
	`111`	`+ data=req_data,`
	`112`	`+ headers=expected_headers,`
	`113`	`+ method="GET",`
	`114`	`+ url=expected_uri,`
	`115`	`+ timeout=None,`
`108`	`116`	`)`
Original file line number	Diff line number	Diff line change
`@@ -1552,6 +1552,7 @@ def test_get_table_sets_user_agent(self):`
`1552`	`1552`	`"User-Agent": expected_user_agent,`
`1553`	`1553`	`},`
`1554`	`1554`	`data=mock.ANY,`
	`1555`	`+ timeout=None,`
`1555`	`1556`	`)`
`1556`	`1557`	`self.assertIn("my-application/1.2.3", expected_user_agent)`
`1557`	`1558`