improve test coverage

jkwlui · jkwlui · commit bae8997203a0 · 2020-01-08T18:02:07.000-08:00
diff --git a/api_core/tests/unit/test_iam.py b/api_core/tests/unit/test_iam.py
@@ -74,10 +74,13 @@ def test___setitem__(self):
         USER = "user:phred@example.com"
         PRINCIPALS = set([USER])
         policy = self._make_one()
-        policy["rolename"] = [USER]
-        assert policy["rolename"] == PRINCIPALS
-        assert len(policy) == 1
-        assert dict(policy) == {"rolename": PRINCIPALS}
+        policy.bindings = [
+            {"role": "role/reader", "members": {USER}},
+            {"role": "role/writer", "members": {USER}},
+        ]
+        assert policy["role/reader"] == PRINCIPALS
+        assert len(policy) == 2
+        assert dict(policy) == {"role/reader": PRINCIPALS, "role/writer": PRINCIPALS}
 
     def test__set_item__overwrite(self):
         USER = "user:phred@example.com"
