fix(automl): pass params to underlying client (#9794)

sirtorry · busunkim96 · commit b3ebd13ab126 · 2019-11-15T15:10:42.000-08:00
diff --git a/packages/google-cloud-automl/google/cloud/automl_v1beta1/tables/tables_client.py b/packages/google-cloud-automl/google/cloud/automl_v1beta1/tables/tables_client.py
@@ -2596,6 +2596,7 @@ def predict(
         model=None,
         model_name=None,
         model_display_name=None,
+        params=None,
         project=None,
         region=None,
         **kwargs
@@ -2642,6 +2643,9 @@ def predict(
                 The `model` instance you want to predict with . This must be
                 supplied if `model_display_name` or `model_name` are not
                 supplied.
+            params (dict[str, str]):
+                `feature_importance` can be set as True to enable local
+                explainability. The default is false.
 
         Returns:
             A :class:`~google.cloud.automl_v1beta1.types.PredictResponse`
@@ -2683,7 +2687,7 @@ def predict(
 
         request = {"row": {"values": values}}
 
-        return self.prediction_client.predict(model.name, request, **kwargs)
+        return self.prediction_client.predict(model.name, request, params, **kwargs)
 
     def batch_predict(
         self,
diff --git a/packages/google-cloud-automl/tests/unit/gapic/v1beta1/test_tables_client_v1beta1.py b/packages/google-cloud-automl/tests/unit/gapic/v1beta1/test_tables_client_v1beta1.py
@@ -1117,7 +1117,7 @@ def test_predict_from_array(self):
         client = self.tables_client({"get_model.return_value": model}, {})
         client.predict(["1"], model_name="my_model")
         client.prediction_client.predict.assert_called_with(
-            "my_model", {"row": {"values": [{"string_value": "1"}]}}
+            "my_model", {"row": {"values": [{"string_value": "1"}]}}, None
         )
 
     def test_predict_from_dict(self):
@@ -1134,6 +1134,7 @@ def test_predict_from_dict(self):
         client.prediction_client.predict.assert_called_with(
             "my_model",
             {"row": {"values": [{"string_value": "1"}, {"string_value": "2"}]}},
+            None,
         )
 
     def test_predict_from_dict_missing(self):
@@ -1148,7 +1149,9 @@ def test_predict_from_dict_missing(self):
         client = self.tables_client({"get_model.return_value": model}, {})
         client.predict({"a": "1"}, model_name="my_model")
         client.prediction_client.predict.assert_called_with(
-            "my_model", {"row": {"values": [{"string_value": "1"}, {"null_value": 0}]}}
+            "my_model",
+            {"row": {"values": [{"string_value": "1"}, {"null_value": 0}]}},
+            None,
         )
 
     def test_predict_all_types(self):
@@ -1210,6 +1213,7 @@ def test_predict_all_types(self):
                     ]
                 }
             },
+            None,
         )
 
     def test_predict_from_array_missing(self):

Original file line number	Diff line number	Diff line change
`@@ -1117,7 +1117,7 @@ def test_predict_from_array(self):`
`1117`	`1117`	`client = self.tables_client({"get_model.return_value": model}, {})`
`1118`	`1118`	`client.predict(["1"], model_name="my_model")`
`1119`	`1119`	`client.prediction_client.predict.assert_called_with(`
`1120`		`- "my_model", {"row": {"values": [{"string_value": "1"}]}}`
	`1120`	`+ "my_model", {"row": {"values": [{"string_value": "1"}]}}, None`
`1121`	`1121`	`)`
`1122`	`1122`
`1123`	`1123`	`def test_predict_from_dict(self):`
`@@ -1134,6 +1134,7 @@ def test_predict_from_dict(self):`
`1134`	`1134`	`client.prediction_client.predict.assert_called_with(`
`1135`	`1135`	`"my_model",`
`1136`	`1136`	`{"row": {"values": [{"string_value": "1"}, {"string_value": "2"}]}},`
	`1137`	`+ None,`
`1137`	`1138`	`)`
`1138`	`1139`
`1139`	`1140`	`def test_predict_from_dict_missing(self):`
`@@ -1148,7 +1149,9 @@ def test_predict_from_dict_missing(self):`
`1148`	`1149`	`client = self.tables_client({"get_model.return_value": model}, {})`
`1149`	`1150`	`client.predict({"a": "1"}, model_name="my_model")`
`1150`	`1151`	`client.prediction_client.predict.assert_called_with(`
`1151`		`- "my_model", {"row": {"values": [{"string_value": "1"}, {"null_value": 0}]}}`
	`1152`	`+ "my_model",`
	`1153`	`+ {"row": {"values": [{"string_value": "1"}, {"null_value": 0}]}},`
	`1154`	`+ None,`
`1152`	`1155`	`)`
`1153`	`1156`
`1154`	`1157`	`def test_predict_all_types(self):`
`@@ -1210,6 +1213,7 @@ def test_predict_all_types(self):`
`1210`	`1213`	`]`
`1211`	`1214`	`}`
`1212`	`1215`	`},`
	`1216`	`+ None,`
`1213`	`1217`	`)`
`1214`	`1218`
`1215`	`1219`	`def test_predict_from_array_missing(self):`